Skip to content

Commit 38bda20

Browse files
authored
Default $value to null in Suspension::resume (#19)
Often there's no need for a value, and we just want to resume at the suspension point. Fixes #11.
1 parent 8580bcc commit 38bda20

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

examples/http-client-suspension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function fetch(string $url): string
3030
\stream_set_blocking($stream, false);
3131

3232
// wait for connection success/error
33-
$watcher = EventLoop::onWritable($stream, fn () => $suspension->resume(null));
33+
$watcher = EventLoop::onWritable($stream, fn () => $suspension->resume());
3434
$suspension->suspend();
3535
EventLoop::cancel($watcher);
3636

@@ -40,7 +40,7 @@ function fetch(string $url): string
4040
$buffer = '';
4141

4242
// wait for HTTP response
43-
$watcher = EventLoop::onReadable($stream, fn () => $suspension->resume(null));
43+
$watcher = EventLoop::onReadable($stream, fn () => $suspension->resume());
4444

4545
do {
4646
$suspension->suspend();

examples/invalid-callback-return.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
print "Caught SIGINT, exiting..." . PHP_EOL;
1616

17-
$suspension->resume(null);
17+
$suspension->resume();
1818

1919
return new \stdClass();
2020
});

examples/stdin-timeout.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
print "Read " . \strlen($chunk) . " bytes" . PHP_EOL;
2323

24-
$suspension->resume(null);
24+
$suspension->resume();
2525
});
2626

27-
$timeoutWatcher = EventLoop::delay(5000, fn () => $suspension->resume(null));
27+
$timeoutWatcher = EventLoop::delay(5000, fn () => $suspension->resume());
2828

2929
$suspension->suspend();
3030

examples/stdin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
print "Read " . \strlen($chunk) . " bytes" . PHP_EOL;
2323

24-
$suspension->resume(null);
24+
$suspension->resume();
2525
});
2626

2727
$suspension->suspend();

examples/timers.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
print "++ Executing watcher created by Loop::delay()" . PHP_EOL;
1616

1717
EventLoop::cancel($repeatWatcher);
18-
$suspension->resume(null);
18+
$suspension->resume();
1919

2020
print "++ Executed after script ended" . PHP_EOL;
2121
});

src/EventLoop/Suspension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function throw(\Throwable $throwable): void
5959
}
6060
}
6161

62-
public function resume(mixed $value): void
62+
public function resume(mixed $value = null): void
6363
{
6464
if (!$this->pending) {
6565
throw $this->error ?? new \Error('Must call suspend() before calling resume()');

test/EventLoopTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function testOnReadable(): void
3838
EventLoop::cancel($callbackId);
3939
$count++;
4040

41-
$suspension->resume(null);
41+
$suspension->resume();
4242
});
4343

4444
$suspension->suspend();
@@ -56,7 +56,7 @@ public function testOnWritable(): void
5656
EventLoop::cancel($callbackId);
5757
$count++;
5858

59-
$suspension->resume(null);
59+
$suspension->resume();
6060
});
6161

6262
$suspension->suspend();

0 commit comments

Comments
 (0)