Skip to content

Encode oauth_token. Fixes #1495 #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Encode oauth_token. Fixes #1495 #1498

merged 2 commits into from
Sep 17, 2020

Conversation

sharok
Copy link
Contributor

@sharok sharok commented Sep 11, 2020

Description

In reference to #1495

According to RFC, the oauth_token must be encoded. Some OAuth providers return token that contains = symbol, the current implementation doesn't encode it to %3D. This PR adding encoding for oauth_token.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alexeyzimarev
Copy link
Member

Thanks for the PR! Is there a way to add a test, which would prevent this issue from popping up in the future?

@sharok
Copy link
Contributor Author

sharok commented Sep 15, 2020

@alexeyzimarev just added the test.

@alexeyzimarev alexeyzimarev merged commit 4daaf69 into restsharp:dev Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants