Skip to content

Commit dd52ff6

Browse files
Re-instate old methods, but as obsolete (#2228)
1 parent a9ccd53 commit dd52ff6

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

src/RestSharp/Options/RestClientOptions.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,16 @@ public RestClientOptions(string baseUrl) : this(new Uri(Ensure.NotEmptyString(ba
181181
/// </summary>
182182
public CookieContainer? CookieContainer { get; set; }
183183

184+
/// <summary>
185+
/// Maximum request duration in milliseconds. When the request timeout is specified using <seealso cref="RestRequest.Timeout"/>,
186+
/// the lowest value between the client timeout and request timeout will be used.
187+
/// </summary>
188+
[Obsolete("Use Timeout instead.")]
189+
public int MaxTimeout {
190+
get => (int) (Timeout?.TotalMilliseconds ?? 0);
191+
set => Timeout = TimeSpan.FromMilliseconds(value);
192+
}
193+
184194
/// <summary>
185195
/// Request duration. Used when the request timeout is not specified using <seealso cref="RestRequest.Timeout"/>,
186196
/// </summary>

src/RestSharp/RestClient.Extensions.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ namespace RestSharp;
2020
[PublicAPI]
2121
public static partial class RestClientExtensions {
2222
[PublicAPI]
23-
public static ValueTask<RestResponse<T>> Deserialize<T>(this IRestClient client, RestResponse response, CancellationToken cancellationToken)
23+
[Obsolete("Please use the async overload with a cancellation token")]
24+
public static RestResponse<T> Deserialize<T>(this IRestClient client, RestResponse response)
25+
=> AsyncHelpers.RunSync(() => client.Serializers.Deserialize<T>(response.Request, response, client.Options, CancellationToken.None).AsTask());
26+
27+
[PublicAPI]
28+
public static ValueTask<RestResponse<T>> Deserialize<T>(this IRestClient client, RestResponse response, CancellationToken cancellationToken)
2429
=> client.Serializers.Deserialize<T>(response.Request, response, client.Options, cancellationToken);
2530

2631
/// <summary>

0 commit comments

Comments
 (0)