Skip to content

Conversation

@igalshilman
Copy link
Contributor

No description provided.

@igalshilman igalshilman requested a review from Copilot May 12, 2025 10:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces minor type hint improvements to enhance the precision of generic types across promise-related and awaitable functions.

  • Updated function signatures in server_context.py and context.py to include an optional "type_hint" parameter while refining return type annotations.
  • Adjusted example code in workflow.py and virtual_object.py to pass explicit type hints where applicable.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
python/restate/server_context.py Updated promise signature with type_hint parameter and added await method implementation.
python/restate/context.py Revised return type annotations and added type_hint parameter to functions.
examples/workflow.py Passed explicit type hint in the promise call.
examples/virtual_object.py Passed explicit type hint to get method for retrieving counter value.

@igalshilman igalshilman merged commit b44581f into restatedev:main May 12, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant