Introduce version barrier for enabling journal v2 by default #3953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
version-barrier
branch
from
56274ed to
9ef76e4
Compare
…ice invocation ingestion logic to write the journal v2
… and then tries to read from journal table v1
…tever reason the negotiated protocol when invoking will be less than 4.
…he problematic situations. Fix some incorrectly handled corner cases, such as deletion of journal when the pinned deployment is not set yet.
…tion. See the changes for more details.
This case can happen if we got an invocation scheduled (or inboxed) before the journal v2 default feature was enabled.
The version barrier requiring min Restate version v1.6.0 will enable the journal v2 by default. It will be written when becoming leader and running at least v1.7.0. Writing the journal v2 by default changes the logic of the state machine. That's why we are guarding it with a version barrier so that during a rolling upgrade the state machine state won't diverge. A concrete problem is that Restart as new with a non-zero prefix would fail on a node that didn't store the journal entries in the journal v2 table.
tillrohrmann
force-pushed
the
version-barrier
branch
from
9ef76e4 to
0f2b55d
Compare
Contributor
|
@tillrohrmann shall i address the comment you made in my pr here directly? Or i do it on my pr and then you rebase here? |
Contributor
Author
Whatever is easier for you. I don't have a strong opinion. Sorry that I changed the rstest in my PR here w/o waiting for you to get back on that to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version barrier requiring min Restate version v1.6.0 will enable the
journal v2 by default. It will be written when becoming leader and running
at least v1.7.0.
Writing the journal v2 by default changes the logic of the state machine. That's
why we are guarding it with a version barrier so that during a rolling upgrade the
state machine state won't diverge. A concrete problem is that Restart as new with
a non-zero prefix would fail on a node that didn't store the journal entries in the
journal v2 table.
This PR is based on #3921.