[PartitionStore] Separate concrete keys from key builder #3917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2025
Merged
tillrohrmann
approved these changes
Oct 20, 2025
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Nice improvements @AhmedSoliman. Thanks a lot for improving the TableKey types. LGTM. +1 for merging :-)
This introduces `restate-lite` a crate that provides restate core functionality as a library. The library is intended to be used in developement or testing use cases. Therefore, it uses defaults tuned for for that purpose.
A developer-focused version of restate that's embedded into the restate CLI. It starts restate on an ephemeral temporary directory that's auto-deleted after Ctrl+C. 1. Supports --use-random-ports 2. Emits very clean output, it doesn't show the server log. Just a table of addresses. 3. Opens the admin UI automatically on startup in the browser 4. Runs the Counter service on a random port and auto-registers it by default so you can play with the UI immediately with that service. 5. Supports --retain to persist the temporary directory (meant to be used in debugging) and currently it doesn't support choosing your own directory
Better type separation between keys and key prefix builders leads to removal of unnecessary "expect()" calls, increased efficiency (Option adds 8 bytes on each field on the key), and safer code. You can only deserialize full keys, and you can serialize key builders and keys alike.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better type separation between keys and key prefix builders leads to removal of unnecessary "expect()" calls, increased efficiency (Option adds 8 bytes on each field on the key), and safer code. You can only deserialize full keys, and you can serialize key builders and keys alike.
Stack created with Sapling. Best reviewed with ReviewStack.