Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attaching to non-idempotent invocations #2205

Open
tillrohrmann opened this issue Nov 4, 2024 · 0 comments
Open

Support attaching to non-idempotent invocations #2205

tillrohrmann opened this issue Nov 4, 2024 · 0 comments

Comments

@tillrohrmann
Copy link
Contributor

Right now, we explicitly forbid attaching to non-idempotent invocations. It is not 100% clear whether there is a strong requirement for it because attaching to a non-idempotent invocation based on its InvocationId should be technically the same as attaching to an idempotent invocation with 0 retention. If the invocation is still pending or running, then we update the ResponseSink to include another sink. If the invocation is not present, then we return a NOT_FOUND_INVOCATION_ERROR.

Originally, we forbid attaching to non-idempotent invocations via #1583. I might have been a remnant from previous times which is no longer valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant