Nit: rename experimental features to just features.

Author: slinkydeveloper

crates/worker/src/partition/mod.rs

@@ -67,7 +67,7 @@ use crate::metric_definitions::{
 };
 use crate::partition::invoker_storage_reader::InvokerStorageReader;
 use crate::partition::leadership::LeadershipState;
-use crate::partition::state_machine::{ActionCollector, ExperimentalFeature, StateMachine};
+use crate::partition::state_machine::{ActionCollector, Feature, StateMachine};
 
 /// Target leader state of the partition processor.
 #[derive(Clone, Copy, Debug, Default, PartialEq)]
@@ -197,7 +197,7 @@ where
         let mut features = EnumSet::new();
         // TODO(till) enable this using partition processor version barrier
         if env::var("RESTATE_EXPERIMENTAL_FEATURE__USE_JOURNAL_V2_BY_DEFAULT").is_ok() {
-            features.insert(ExperimentalFeature::UseJournalTableV2AsDefault);
+            features.insert(Feature::UseJournalTableV2AsDefault);
         }
 
         let state_machine = StateMachine::new(

crates/worker/src/partition/state_machine/entries/mod.rs

@@ -405,7 +405,7 @@ impl<CMD> ApplyJournalCommandEffect<'_, CMD> {
 
 #[cfg(test)]
 mod tests {
-    use crate::partition::state_machine::ExperimentalFeature;
+    use crate::partition::state_machine::Feature;
     use crate::partition::state_machine::tests::fixtures::invoker_entry_effect;
     use crate::partition::state_machine::tests::{TestEnv, fixtures, matchers};
     use bytes::Bytes;
@@ -424,7 +424,7 @@ mod tests {
     #[restate_core::test]
     async fn update_journal_and_commands_length(
         #[values(ExperimentalFeature::UseJournalTableV2AsDefault.into(), EnumSet::empty())]
-        features: EnumSet<ExperimentalFeature>,
+        features: EnumSet<Feature>,
     ) {
         let mut test_env = TestEnv::create_with_experimental_features(features).await;
         let invocation_id = fixtures::mock_start_invocation(&mut test_env).await;

crates/worker/src/partition/state_machine/entries/notification.rs

@@ -201,7 +201,7 @@ where
 mod tests {
     use super::*;
 
-    use crate::partition::state_machine::ExperimentalFeature;
+    use crate::partition::state_machine::Feature;
     use crate::partition::state_machine::tests::{TestEnv, fixtures, matchers};
     use bytes::Bytes;
     use bytestring::ByteString;
@@ -268,7 +268,7 @@ mod tests {
     #[restate_core::test]
     async fn notify_signal_received_before_pinned_deployment(
         #[values(ExperimentalFeature::UseJournalTableV2AsDefault.into(), EnumSet::empty())]
-        features: EnumSet<ExperimentalFeature>,
+        features: EnumSet<Feature>,
     ) {
         let mut test_env = TestEnv::create_with_experimental_features(features).await;
         let invocation_id = fixtures::mock_start_invocation(&mut test_env).await;

crates/worker/src/partition/state_machine/lifecycle/cancel.rs

@@ -118,7 +118,7 @@ mod tests {
     use super::*;
 
     use crate::partition::state_machine::tests::{TestEnv, fixtures, matchers};
-    use crate::partition::state_machine::{Action, ExperimentalFeature};
+    use crate::partition::state_machine::{Action, Feature};
     use crate::partition::types::InvokerEffectKind;
     use assert2::assert;
     use enumset::EnumSet;
@@ -237,10 +237,9 @@ mod tests {
 
     #[restate_core::test]
     async fn cancel_invoked_invocation_without_pinned_deployment_with_journal_table_v2_default() {
-        let mut test_env = TestEnv::create_with_experimental_features(
-            ExperimentalFeature::UseJournalTableV2AsDefault.into(),
-        )
-        .await;
+        let mut test_env =
+            TestEnv::create_with_experimental_features(Feature::UseJournalTableV2AsDefault.into())
+                .await;
         let invocation_id = fixtures::mock_start_invocation(&mut test_env).await;
 
         // Send signal notification before pinning the deployment
@@ -273,7 +272,7 @@ mod tests {
     #[restate_core::test]
     async fn cancel_scheduled_invocation_through_notify_signal(
         #[values(ExperimentalFeature::UseJournalTableV2AsDefault.into(), EnumSet::empty())]
-        features: EnumSet<ExperimentalFeature>,
+        features: EnumSet<Feature>,
     ) -> anyhow::Result<()> {
         let mut test_env = TestEnv::create_with_experimental_features(features).await;
 
@@ -348,7 +347,7 @@ mod tests {
     #[restate_core::test]
     async fn cancel_inboxed_invocation_through_notify_signal(
         #[values(ExperimentalFeature::UseJournalTableV2AsDefault.into(), EnumSet::empty())]
-        features: EnumSet<ExperimentalFeature>,
+        features: EnumSet<Feature>,
     ) -> anyhow::Result<()> {
         let mut test_env = TestEnv::create_with_experimental_features(features).await;
 

crates/worker/src/partition/state_machine/lifecycle/restart_as_new.rs

@@ -280,7 +280,7 @@ where
 mod tests {
     use super::*;
 
-    use crate::partition::state_machine::ExperimentalFeature;
+    use crate::partition::state_machine::Feature;
     use crate::partition::state_machine::tests::{TestEnv, fixtures, matchers};
     use googletest::prelude::*;
     use restate_storage_api::invocation_status_table::{
@@ -382,10 +382,9 @@ mod tests {
     async fn restart_killed_invocation() {
         // This works only when using journal table v2 as default!
         // The corner case with journal table v1 is handled by the rpc handler instead.
-        let mut test_env = TestEnv::create_with_experimental_features(
-            ExperimentalFeature::UseJournalTableV2AsDefault.into(),
-        )
-        .await;
+        let mut test_env =
+            TestEnv::create_with_experimental_features(Feature::UseJournalTableV2AsDefault.into())
+                .await;
 
         // Start invocation, then kill it
         let invocation_target = InvocationTarget::mock_virtual_object();

crates/worker/src/partition/state_machine/mod.rs

@@ -117,7 +117,7 @@ use crate::partition::state_machine::lifecycle::OnCancelCommand;
 use crate::partition::types::{InvokerEffect, InvokerEffectKind, OutboxMessageExt};
 
 #[derive(Debug, Hash, enumset::EnumSetType, strum::Display)]
-pub enum ExperimentalFeature {
+pub enum Feature {
     UseJournalTableV2AsDefault,
 }
 
@@ -136,7 +136,7 @@ pub struct StateMachine {
     pub(crate) partition_key_range: RangeInclusive<PartitionKey>,
 
     /// Enabled experimental features.
-    pub(crate) experimental_features: EnumSet<ExperimentalFeature>,
+    pub(crate) features: EnumSet<Feature>,
 }
 
 impl Debug for StateMachine {
@@ -221,7 +221,7 @@ impl StateMachine {
         outbox_head_seq_number: Option<MessageIndex>,
         partition_key_range: RangeInclusive<PartitionKey>,
         min_restate_version: SemanticRestateVersion,
-        experimental_features: EnumSet<ExperimentalFeature>,
+        experimental_features: EnumSet<Feature>,
         schema: Option<Schema>,
     ) -> Self {
         Self {
@@ -230,7 +230,7 @@ impl StateMachine {
             outbox_head_seq_number,
             partition_key_range,
             min_restate_version,
-            experimental_features,
+            features: experimental_features,
             schema,
         }
     }
@@ -247,8 +247,7 @@ pub(crate) struct StateMachineApplyContext<'a, S> {
     min_restate_version: &'a mut SemanticRestateVersion,
     schema: &'a mut Option<Schema>,
     partition_key_range: RangeInclusive<PartitionKey>,
-    #[allow(dead_code)]
-    experimental_features: &'a EnumSet<ExperimentalFeature>,
+    features: &'a EnumSet<Feature>,
     is_leader: bool,
 }
 
@@ -286,7 +285,7 @@ impl StateMachine {
                 min_restate_version: &mut self.min_restate_version,
                 schema: &mut self.schema,
                 partition_key_range: self.partition_key_range.clone(),
-                experimental_features: &self.experimental_features,
+                features: &self.features,
                 is_leader,
             }
             .on_apply(command)
@@ -719,9 +718,7 @@ impl<S> StateMachineApplyContext<'_, S> {
         // A pre-flight invocation has been already deduplicated
 
         // 0. Prepare the journal table v2
-        if self
-            .experimental_features
-            .contains(ExperimentalFeature::UseJournalTableV2AsDefault)
+        if self.features.contains(Feature::UseJournalTableV2AsDefault)
             && let PreFlightInvocationArgument::Input(PreFlightInvocationInput {
                 argument,
                 headers,

crates/worker/src/partition/state_machine/tests/kill_cancel.rs

@@ -32,7 +32,7 @@ use test_log::test;
 #[restate_core::test]
 async fn kill_inboxed_invocation(
     #[values(ExperimentalFeature::UseJournalTableV2AsDefault.into(), EnumSet::empty())]
-    features: EnumSet<ExperimentalFeature>,
+    features: EnumSet<Feature>,
 ) -> anyhow::Result<()> {
     let mut test_env = TestEnv::create_with_experimental_features(features).await;
 

crates/worker/src/partition/state_machine/tests/mod.rs

@@ -90,7 +90,7 @@ impl TestEnv {
     }
 
     pub async fn create_with_experimental_features(
-        experimental_features: EnumSet<ExperimentalFeature>,
+        experimental_features: EnumSet<Feature>,
     ) -> Self {
         Self::create_with_state_machine(StateMachine::new(
             0,    /* inbox_seq_number */