FIX missing namespaced srem? method #224
Conversation
FIX missing namespaced srem? method
FIX add srem_returns_boolean method to namespace
neilchandler
force-pushed
the
FIX_srem_namespacing
branch
from
0cd7fca
to
098d993
Compare
FIX add srem_returns_boolean method to namespace
neilchandler
force-pushed
the
FIX_srem_namespacing
branch
from
658e0a4
to
f274d6f
Compare
| class << self | ||
| attr_accessor :sadd_returns_boolean | ||
| attr_accessor :sadd_returns_boolean, :srem_returns_boolean |
There was a problem hiding this comment.
I've added the boolean here so the use of sadd_returns_boolean in flipper-redis can be updated
with new method redis_srem_returns_boolean? can be added similar to redis_sadd_returns_boolean?.
Then redis_srem_returns_boolean? could be used instead of redis_sadd_returns_boolean?
which would make more sense in this context
|
@neilchandler hey sorry didn't realize this conflicted with #223 before I merged it in. Can you rebase/resolve conflicts and I'll get it in? |
lib/redis/namespace.rb
Outdated
| @@ -138,7 +138,7 @@ class Namespace | |||
| "rpush" => [ :first ], | |||
| "rpushx" => [ :first ], | |||
| "sadd" => [ :first ], | |||
| "sadd?" => [ :first ], | |||
| "sadd?" => [ :first ], | |||
There was a problem hiding this comment.
Already addressed in #223
There was a problem hiding this comment.
This has been addressed in the rebase
neilchandler
force-pushed
the
FIX_srem_namespacing
branch
from
f274d6f
to
6237165
Compare
|
Hey @PatrickTulskie. I've rebased and resolved the conflicts as requested 🙂 |
Hey it still won't let me rebase/merge in your PR due to conflicts. Can you maybe just squash your PR into a single commit and see if that resolves it? |
|
nvm I just did it with github. easy peasy. working on a new release this weekend. |
|
This is in 1.11.0 |
This is an extension of the exising Pull Request #223 to add the missing namespacing to the srem? method