Skip to content

Add sadd_returns_boolean + sadd? method #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add sadd_returns_boolean + sadd? method #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f6dcc
Add sadd_returns_boolean + sadd? method
radar Nov 25, 2022
5f357e7
adding comment about said var
iloveitaly Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/redis/namespace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ class Namespace
"rpush" => [ :first ],
"rpushx" => [ :first ],
"sadd" => [ :first ],
"sadd?" => [ :first ],
"scard" => [ :first ],
"scan" => [ :scan_style, :second ],
"scan_each" => [ :scan_style, :all ],
Expand Down Expand Up @@ -239,6 +240,13 @@ class Namespace
# Support 1.8.7 by providing a namespaced reference to Enumerable::Enumerator
Enumerator = Enumerable::Enumerator unless defined?(::Enumerator)

# This is used by the Redis gem to determine whether or not to display that deprecation message.
@sadd_returns_boolean = true

class << self
attr_accessor :sadd_returns_boolean
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed, right? Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed, as it provides the way to set and read the sadd_returns_boolean value. This is used by the Redis gem to determine whether or not to display that deprecation message.

attr_writer :namespace
attr_reader :redis
attr_accessor :warning
Expand Down
5 changes: 5 additions & 0 deletions spec/redis_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@
expect(values).to match_array(['banana', 'eggplant'])
end

it "should add a new member" do
expect(@namespaced.sadd?('foo', 1)).to eq(true)
expect(@namespaced.sadd?('foo', 1)).to eq(false)
end

it "should add namespace to sort" do
@namespaced.sadd('foo', 1)
@namespaced.sadd('foo', 2)
Expand Down