Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch numerical scaling to relative #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Oct 24, 2018

Now uses relative scaling, ergo bound * a where a >> 1 instead of just assigning a very large bound. This should maintain a bound structure that is more similar to the original model and lead to less blocked reactions in the reconstruction.

Still requires validation.

@codecov-io
Copy link

Codecov Report

Merging #14 into master will decrease coverage by 0.33%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   92.47%   92.13%   -0.34%     
==========================================
  Files           3        3              
  Lines         226      229       +3     
  Branches       63       63              
==========================================
+ Hits          209      211       +2     
- Misses          9       10       +1     
  Partials        8        8
Impacted Files Coverage Δ
corda/corda.py 92.7% <75%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f4a8e...ee7b77c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants