try avoinding race conditions of sub processes not being closed

Author: gabrielmfern

benchmarks/preview-server/src/local-vs-2.1.7-canary.2-on-startup.ts

@@ -21,14 +21,22 @@ const bench = new Bench({
 
 bench
   .add('startup on local', async () => {
-    const server = await runServer(pathToLocalCliScript);
-    await fetch(`${server.url}/preview/magic-links/notion-magic-link`);
-    server.subprocess.kill();
+    try {
+      const server = await runServer(pathToLocalCliScript);
+      await fetch(`${server.url}/preview/magic-links/notion-magic-link`);
+      if (!server.subprocess.kill()) {
+        throw new Error('could not close sub process for preview server');
+      }
+    } catch (err) {
+      console.error('Error starting local server:', err);
+    }
   })
   .add('startup on 2.1.7-canary.2', async () => {
     const server = await runServer(pathToCanaryCliScript);
     await fetch(`${server.url}/preview/magic-links/notion-magic-link`);
-    server.subprocess.kill();
+    if (!server.subprocess.kill()) {
+      throw new Error('could not close sub process for preview server');
+    }
   });
 
 await bench.run();

benchmarks/preview-server/src/utils/run-server.ts

@@ -11,7 +11,25 @@ export interface Server {
 export function runServer(pathToCliScript: string) {
   return new Promise<Server>((resolve, reject) => {
     const node = spawn('node', [pathToCliScript, 'dev'], {
-      cwd: path.resolve(__dirname, '../../../../apps/demo'),
+      cwd: path.resolve(import.meta.dirname, '../../../../apps/demo'),
+    });
+
+    const kill = () => {
+      node.kill();
+    };
+
+    process.addListener('exit', kill);
+    process.addListener('SIGINT', kill);
+    process.addListener('SIGTERM', kill);
+    process.addListener('SIGUSR1', kill);
+    process.addListener('SIGUSR2', kill);
+
+    node.on('close', () => {
+      process.removeListener('exit', kill);
+      process.removeListener('SIGINT', kill);
+      process.removeListener('SIGTERM', kill);
+      process.removeListener('SIGUSR1', kill);
+      process.removeListener('SIGUSR2', kill);
     });
 
     node.stdout.on('data', (data) => {