feat: interactive debug builder #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: when large builds (spack) fail, we have to start over. Solution: prototype a debug solution that, when a flag -i (for interactive) is added for a custom build entrypoint, we allow a dispatchRun builder command to fail, and still commit the layer. This means we have the changes regardless of the exit code. Note that this is implemented for the Dockerfile builder but not yet buildkit, which has another grpc call that I have not looked at yet. It should be considered a proof of concept. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when large builds (spack) fail, we have to start over. Solution: prototype a debug solution that, when a flag -i (for interactive) is added for a custom build entrypoint, we allow a dispatchRun builder command to fail, and still commit the layer. This means we have the changes regardless of the exit code. Note that this is implemented for the Dockerfile builder but not yet buildkit, which has another grpc call that I have not looked at yet. It should be considered a proof of concept.
Putting a PR against my own repository so I can see it! I can't believe this worked, and it was so easy to read the code after months of reading Kubernetes... 😆
- A picture of a cute animal (not mandatory but encouraged)
Does this count?