Unify comment formatting inside the empty blocks

[zheyz]

Unify the format of comments inside the empty block

// before
let foo = [// hi
]

let foo = [//hi
/* hi */]

// now -- same as prettier
let foo = [
  // hi
]

let foo = [
  // hi
 /* hi */
]

[IwanKaramazow]

Can we tweak the output to look more like the input:

type fn = {
   /* comment1 */
   // comment2
 }

[IwanKaramazow]

The comments inside look a bit suboptimal, can we go for:

{
   /* comment1 */
   // comment2
 }

[cknitt]

Also, I just fixed CI, please rebase on latest master to get CI to run.

[zheyz]

Could we keep tags open if these are comments inside? @cknitt
I found this change was introduced in e913c4c

[cknitt]

Fine with me! That would make it easier to add code after the comment anyway.

[cristianoc]

Has the scope of this PR changed?
There seem to be differences outside empty records.

[zheyz]

Yes. Now this PR is for adjusting the comments format inside an empty block(list, record, etc)

[cristianoc]

Yes. Now this PR is for adjusting the comments format inside an empty block(list, record, etc)

Would you add an entry in the CHANGELOG.md as this is user-visible.
@IwanKaramazow any more comments?

[IwanKaramazow]

If a user wrote [/* a */], can we keep it on one line? Similar for the other "empty nodes".

We tend to look at the style of the author: did he write it over multiple lines or not?

• If it is on one line, keep it on one line (unless it breaks the column width).
• If it is written over multiple lines, force break it over multiple lines.

[zheyz]

That sounds reasonable, will fix it later.

[cristianoc]

This does the job but looks like tight coupling at a distance.
When is it that printCommentsInside currently produces Nil, and can we get hold of that information instead (e.g. return an optional).

[IwanKaramazow]

Yes, in an ideal world, we shouldn't inspect the contents of a doc to make formatting decisions. The information we go off is the AST (+ comments).

@ah-yu is the isNil absolutely necessary?

[zheyz]

isNil is only used in the development phase, then I could do a quick test without too many code changes.

Forgot to clean it up and will do it later.

[cristianoc]

Can use find_opt

[cristianoc]

@ah-yu just ping when this is ready.

[zheyz]

@cristianoc done

[cristianoc]

@cristianoc done

Thanks a lot for contributing this!