Tweak poly var printing in outcome printer

Author: Iwan

src/res_outcome_printer.ml

@@ -29,7 +29,7 @@ let classifyIdentContent ~allowUident txt =
       let c = String.unsafe_get txt i in
       if i == 0 && not (
         (allowUident && (c >= 'A' && c <= 'Z')) ||
-        (c >= 'a' && c <= 'z') || c = '_' || (c >= '0' && c <= '9')) then
+        (c >= 'a' && c <= 'z') || c = '_') then
         ExoticIdent
       else if not (
            (c >= 'a' && c <= 'z')
@@ -56,6 +56,15 @@ let printIdentLike ~allowUident txt =
     ]
   | NormalIdent -> Doc.text txt
 
+let printPolyVarIdent txt =
+  match classifyIdentContent ~allowUident:true txt with
+  | ExoticIdent -> Doc.concat [
+     Doc.text "\"";
+     Doc.text txt;
+     Doc.text"\""
+   ]
+  | NormalIdent -> Doc.text txt
+
   (* ReScript doesn't have parenthesized identifiers.
    * We don't support custom operators. *)
    let parenthesized_ident _name = true
@@ -376,7 +385,7 @@ let printIdentLike ~allowUident txt =
              Doc.group (
                Doc.concat [
                  Doc.text "#";
-                 printIdentLike ~allowUident:true name;
+                 printPolyVarIdent name;
                  match types with
                  | [] -> Doc.nil
                  | types ->

tests/oprint/oprint.res

@@ -135,6 +135,12 @@ let computeAreaPlus = (sp: shapePlus) =>
   | #...shape as s => computeArea(s)
   }
 
+let computeAreaExotic = (sp) =>
+  switch sp {
+  | #"R-Triangle+"(_p1, _p2, _p3) => () 
+  | #...shape as s => ignore(s); ()
+  }
+
 let top = #Point(3.0, 5.0)
 let left = #Point(0.0, 0.0)
 let right = #Point(3.0, 0.0)
@@ -183,6 +189,11 @@ type t21 = [#"va r ia nt"]
 type t22 = [#"Variant ⛰"]
 type \"let" = int
 type \"type" = [ #"Point🗿"(\"let", float) ]
+type t23 = [
+  | #"1"
+  | #"10space"
+  | #"123"
+]
 
 type exoticUser = {
   \"let": string,

tests/oprint/oprint.res.snapshot

@@ -100,6 +100,11 @@ type shapePlus = [
   | #Triangle(point, point, point)
 ]
 let computeAreaPlus: shapePlus => float
+let computeAreaExotic: [<
+  | #Circle(point, float)
+  | #"R-Triangle+"('a, 'b, 'c)
+  | #Rectangle(point, point)
+] => unit
 let top: [> #Point(float, float)]
 let left: [> #Point(float, float)]
 let right: [> #Point(float, float)]
@@ -137,11 +142,12 @@ module type Conjunctive = {
   let f: [< #T([< u2]) & ([< u2]) & ([< u1])] => unit
   let g: [< #S & ([< u2]) & ([< u2]) & ([< u1])] => unit
 }
-type t20 = [#\"type"]
-type t21 = [#\"va r ia nt"]
-type t22 = [#\"Variant ⛰"]
+type t20 = [#"type"]
+type t21 = [#"va r ia nt"]
+type t22 = [#"Variant ⛰"]
 type \"let" = int
-type \"type" = [#\"Point🗿"(\"let", float)]
+type \"type" = [#"Point🗿"(\"let", float)]
+type t23 = [#"1" | #"10space" | #"123"]
 type exoticUser = {\"let": string, \"type": float}
 module Js = {
   module Fn = {