Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core tests #7116

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Add Core tests #7116

merged 7 commits into from
Oct 22, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 22, 2024

Followup to #7108. This adds the Core tests to the compiler repo and runs them in CI.

With the exception of the doc tests, as those require @rescript/tools, and it feels a bit weird depending on that in the compiler repo. Shouldn't we better move the tools sources into the compiler repo (see #7000)?

@cknitt cknitt marked this pull request as draft October 22, 2024 07:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax Benchmarks

Benchmark suite Current: 1a71d14 Previous: e1b7fb7 Ratio
Parse RedBlackTree.res - time/run 1.2423973466666667 ms 1.2123143266666667 ms 1.02
Parse RedBlackTree.res - allocs/run 199057 words 199057 words 1
Print RedBlackTree.res - time/run 2.2982388466666666 ms 2.3104395133333333 ms 0.99
Print RedBlackTree.res - allocs/run 236403 words 236403 words 1
Print RedBlackTreeNoComments.res - time/run 2.0974250866666666 ms 2.10057036 ms 1.00
Print RedBlackTreeNoComments.res - allocs/run 249186 words 249186 words 1
Parse Napkinscript.res - time/run 39.136509399999994 ms 39.28006235333333 ms 1.00
Parse Napkinscript.res - allocs/run 8670066 words 8670066 words 1
Print Napkinscript.res - time/run 74.23746414666667 ms 77.00100409999999 ms 0.96
Print Napkinscript.res - allocs/run 9776327 words 9776327 words 1
Parse HeroGraphic.res - time/run 5.092819533333333 ms 5.13472718 ms 0.99
Parse HeroGraphic.res - allocs/run 1219326 words 1219326 words 1
Print HeroGraphic.res - time/run 8.726399593333332 ms 8.775952553333333 ms 0.99
Print HeroGraphic.res - allocs/run 1396466 words 1396466 words 1

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt changed the title WIP: Add Core tests Add Core tests Oct 22, 2024
@cknitt cknitt marked this pull request as ready for review October 22, 2024 14:57
@cknitt cknitt requested review from zth and cristianoc October 22, 2024 14:59
@cknitt cknitt merged commit 4c28fa1 into master Oct 22, 2024
20 checks passed
@cknitt cknitt deleted the core-tests branch October 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants