Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rescript-editor-analysis and rescript-tools into compiler repo #7000

Merged
merged 46 commits into from
Nov 12, 2024
Merged

Move rescript-editor-analysis and rescript-tools into compiler repo #7000

merged 46 commits into from
Nov 12, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 1, 2024 •
edited
Loading

  • Moved rescript-editor-analysis and rescript-tools from rescript-vscode repo into the compiler repo
  • Moved all tests into the tests folder
  • Adapted to all the v12 and uncurried changes and get tests to run again (thanks @zth for your help!)
  • Integrated build procedure and test running with the CI setup in the compiler repo
  • rescript-tools.exe and rescript-analysis.exe are now part of the rescript npm package

Further cleanup to follow in separate PRs.

cknitt
cknitt commented Sep 1, 2024
View reviewed changes
analysis/src/Xform.ml Outdated Show resolved Hide resolved
@cknitt cknitt mentioned this pull request Oct 9, 2024
Merged
@cknitt cknitt mentioned this pull request Oct 22, 2024
Merged
@cknitt cknitt force-pushed the vscode-extension branch 6 times, most recently from 1277154 to 54d9af6 Compare November 2, 2024 11:52
@cknitt cknitt changed the title WIP: Move VS Code extension into compiler repo WIP: Move rescript-editor-analysis and rescript-tools into compiler repo Nov 2, 2024
@cknitt
Dune: explicitly set package to "rescript" before adding more packages
6c40788
@cknitt
Add package "analysis" from rescript-vscode repo
6904577
@cknitt
Analysis: remove vendored libs that are already in the compiler repo
3fceca8
@cknitt
Add Tast_iterator module from rescript-vscode repo
dbd577b
@cknitt
Remove class stuff from Tast_iterator
e3acfb1
@cknitt
Format Tast_iterator
0716c1f
@cknitt
Fix DeadValue.ml
0b82fa5
@cknitt
No more Config.uncurried
23502b5
@cknitt
Analysis: use default print width instead of taking it from syntax cli
20de8dd
@cknitt
Make pexp_attributes mutable
ede3dba
@cknitt
Add package "tools" from rescript-vscode repo
3cdce12
@cknitt
Format OCaml code
a764250
@cknitt
Mark Res_multi_printer.default_print_width as live
8c76c29
@cknitt
Format
df18fa1
@cknitt
Do not check in tools/analysis test artifacts
ba56a9e
@cknitt
Add rescript-editor-analysis and rescript-tools to rescript npm package
12df921
@cknitt
Fix path for analysis/tools binaries in test scripts
c8c627e
@cknitt
Run analysis tests in CI
7f48594
@cknitt
analysis: get rid of PervasivesU
6426d79
@cknitt cknitt marked this pull request as ready for review November 11, 2024 15:49
@cknitt cknitt changed the title WIP: Move rescript-editor-analysis and rescript-tools into compiler repo Move rescript-editor-analysis and rescript-tools into compiler repo Nov 11, 2024
@cknitt cknitt marked this pull request as draft November 11, 2024 16:04
@cknitt cknitt force-pushed the vscode-extension branch 3 times, most recently from 1beff72 to cb9cc31 Compare November 11, 2024 19:22
@cknitt cknitt marked this pull request as ready for review November 11, 2024 19:41
@cknitt cknitt merged commit 4a748bb into master Nov 12, 2024
20 checks passed
@cknitt cknitt deleted the vscode-extension branch November 12, 2024 07:48
cristianoc
cristianoc reviewed Nov 12, 2024
View reviewed changes
analysis/README.md

## Overview

See main CONTRIBUTING.md's repo structure. Additionally, `examples/` is a convenience debugging repo. Check out `test.sh` (invoked through `make test`) to see the snapshots testing workflow stored in `tests/`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess changes to CONTRIBUTING are coming in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, still some stuff to clean up, and also to move/add to the root Makefile.

@nojaf
Copy link
Contributor

nojaf commented Nov 15, 2024

@cknitt were the ReScript bindings in https://github.com/rescript-lang/rescript/tree/master/tools forgotten or deliberately not moved?

Would like to change https://github.com/rescript-lang/rescript-vscode/blob/2837e0813385b9438f15898214cf7f3b7521f3dd/tools/npm/Tools_Docgen.resi#L102 to Core.

@cknitt
Copy link
Member Author

cknitt commented Nov 15, 2024

Neither 🙂, they are now here: https://github.com/rescript-lang/rescript/blob/master/runtime/RescriptTools_Docgen.res

(But this location may be temporary, as they clutter up the global namespace that way.)

@nojaf
Copy link
Contributor

nojaf commented Nov 15, 2024

Okay, and did you port the most recent code?
At first glance the changes of rescript-lang/rescript-vscode#1043 seem to be missing.

@cknitt
Copy link
Member Author

cknitt commented Nov 15, 2024

This may well be as I initially opened this PR on Sep 1 (it took a while to get everything working), and did not re-sync anything after that.
Could you sync what is missing?

@nojaf
Copy link
Contributor

nojaf commented Nov 15, 2024

Yep, will do, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@zth zth Awaiting requested review from zth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cknitt @nojaf @cristianoc @zth