Run OCaml format check as part of CI tests

Author: cknitt

Makefile

@@ -75,7 +75,7 @@ format:
 	dune build @fmt --auto-promote
 
 checkformat:
-	dune build @fmt
+	node scripts/check_format.sh
 
 clean-gentype:
 	make -C jscomp/gentype_tests/typescript-react-example clean

scripts/check_format.sh

@@ -0,0 +1,20 @@
+#!/bin/bash
+
+warningYellow='\033[0;33m'
+successGreen='\033[0;32m'
+reset='\033[0m'
+
+case "$(uname -s)" in
+  Darwin|Linux)
+    echo "Checking code formatting..."
+    if opam exec -- dune build @fmt; then
+      printf "${successGreen}✅ OCaml code formatting ok.${reset}\n"
+    else
+      printf "${warningYellow}⚠️ OCaml code formatting issues found.${reset}\n"
+      exit 1
+    fi
+    ;;
+  *)
+    # Does not work on Windows
+    echo "OCaml code formatting check skipped for this platform."
+esac

scripts/ciTest.js

@@ -90,6 +90,11 @@ async function runTests() {
       cwd: path.join(__dirname, ".."),
       stdio: [0, 1, 2],
     });
+
+    cp.execSync("bash scripts/check_format.sh", {
+      cwd: path.join(__dirname, ".."),
+      stdio: [0, 1, 2],
+    });
   }
 }
 

scripts/test_syntax.sh

@@ -115,16 +115,3 @@ fi
 
 rm -r temp/
 popd
-
-# Check format (does not work on Windows)
-case "$(uname -s)" in
-  Darwin|Linux)
-    echo "Checking code formatting..."
-    if opam exec -- dune build @fmt; then
-      printf "${successGreen}✅ Code formatting ok.${reset}\n"
-    else
-      printf "${warningYellow}⚠️ Code formatting failed.${reset}\n"
-      exit 1
-    fi
-    ;;
-esac