Dce command can count the issues.

Author: cristianoc

analysis/reanalyze/src/Arnold.ml

@@ -1418,4 +1418,4 @@ let processCmt (cmt_infos : Cmt_format.cmt_infos) =
   | Implementation structure -> processStructure structure
   | _ -> ()
 
-let reportResults ~ppf = if !Common.Cli.debug then Stats.dump ~ppf
+let reportStats () = Stats.dump ~ppf:Format.std_formatter

analysis/reanalyze/src/DeadCommon.ml

@@ -507,7 +507,7 @@ module Decl = struct
         then Current.maxValuePosEnd := decl.posEnd;
     insideReportedValue
 
-  let report ~ppf decl =
+  let report decl =
     let insideReportedValue = decl |> isInsideReportedValue in
     if decl.report then
       let name, message =
@@ -650,7 +650,7 @@ let rec resolveRecursiveRefs ~checkOptionalArg ~deadDeclarations ~level
           refsString level);
     isDead
 
-let reportDead ~checkOptionalArg ppf =
+let reportDead ~checkOptionalArg =
   let iterDeclInOrder ~deadDeclarations ~orderedFiles decl =
     let refs =
       match decl |> Decl.isValue with
@@ -692,4 +692,4 @@ let reportDead ~checkOptionalArg ppf =
   let sortedDeadDeclarations =
     !deadDeclarations |> List.fast_sort Decl.compareForReporting
   in
-  sortedDeadDeclarations |> List.iter (Decl.report ~ppf)
+  sortedDeadDeclarations |> List.iter Decl.report

analysis/reanalyze/src/Exception.ml

@@ -488,5 +488,3 @@ let processCmt (cmt_infos : Cmt_format.cmt_infos) =
     Values.newCmt ();
     structure |> processStructure
   | _ -> ()
-
-let reportResults ~ppf:_ = Checks.doChecks ()

analysis/reanalyze/src/Reanalyze.ml

@@ -85,17 +85,16 @@ let runAnalysis ~cmtRoot =
   processCmtFiles ~cmtRoot;
   if runConfig.dce then (
     DeadException.forceDelayedItems ();
-    DeadOptionalArgs.forceDelayedItems ())
+    DeadOptionalArgs.forceDelayedItems ();
+    DeadCommon.reportDead ~checkOptionalArg:DeadOptionalArgs.check;
+    WriteDeadAnnotations.write ());
+  if runConfig.exception_ then Exception.Checks.doChecks ();
+  if runConfig.termination && !Common.Cli.debug then Arnold.reportStats ()
 
-let runAnalysisAndReport ~cmtRoot ~ppf =
+let runAnalysisAndReport ~cmtRoot =
   Log_.Color.setup ();
   if !Common.Cli.json then EmitJson.start ();
   runAnalysis ~cmtRoot;
-  if runConfig.dce then (
-    DeadCommon.reportDead ~checkOptionalArg:DeadOptionalArgs.check ppf;
-    WriteDeadAnnotations.write ());
-  if runConfig.exception_ then Exception.reportResults ~ppf;
-  if runConfig.termination then Arnold.reportResults ~ppf;
   Log_.Stats.report ();
   Log_.Stats.clear ();
   if !Common.Cli.json then EmitJson.finish ()
@@ -207,11 +206,10 @@ let cli () =
         "Write @dead annotations directly in the source files" );
     ]
   in
-  let ppf = Format.std_formatter in
   Arg.parse speclist print_endline usage;
   if !analysisKindSet = false then setConfig ();
   let cmtRoot = !cmtRootRef in
-  runAnalysisAndReport ~cmtRoot ~ppf
+  runAnalysisAndReport ~cmtRoot
   [@@raises exit]
 
 module RunConfig = RunConfig

analysis/reanalyze/src/dune

@@ -1,7 +1,7 @@
 (library
  (name reanalyze)
  (flags
-  (-w "-9")
+  (-w "+6+26+27+32+33+39")
   (-open Compilerlibs406)
   (-open Jsonlib)
   (-open Ext))

analysis/src/DceCommand.ml

@@ -1,5 +1,5 @@
 let command () =
   Reanalyze.RunConfig.dce ();
   Reanalyze.runAnalysis ~cmtRoot:None;
-  let issues = Reanalyze.Log_.Stats.getSortedIssues () in
-  Printf.printf "kinds of issues:%d\n" (List.length (fst issues))
+  let issues = !Reanalyze.Log_.Stats.issues in
+  Printf.printf "issues:%d\n" (List.length issues)

analysis/tests/src/expected/Dce.res.txt

@@ -1,3 +1,3 @@
 DCE src/Dce.res
-kinds of issues:0
+issues:233