Fix issue in JSX autocomplete when the component is declared external.

Fixes #307.

Author: cristianoc

CHANGELOG.md

@@ -1,5 +1,5 @@
 ## master
-
+- Fix issue in JSX autocomplete when the component is declared external.
 - Fix jump-to-definition for uncurried calls.
 - Fix issue where values for autocomplete were pulled from implementations instead of interfaces.
 

analysis/src/NewCompletions.ml

@@ -914,6 +914,19 @@ let processCompletable ~findItems ~full ~package ~rawOpens
                 _,
                 _ ) ->
             getFields tObj
+          | Tconstr
+              ( path,
+                [
+                  {
+                    desc =
+                      ( Tconstr (* Js.t *) (_, [{desc = Tobject (tObj, _)}], _)
+                      | Tobject (tObj, _) );
+                  };
+                  _;
+                ],
+                _ )
+            when Path.name path = "React.componentLike" ->
+            getFields tObj
           | _ -> []
         in
         typ |> getLabels

analysis/tests/src/Jsx.res

@@ -49,6 +49,6 @@ module Ext = {
   external make: (~align: string=?) => React.element = "Typography"
 }
 
-let extMake = Ext.make
+let _extMake = Ext.make
 
 //^com <Ext al

analysis/tests/src/expected/Jsx.res.txt

@@ -182,5 +182,17 @@ Definition tests/src/Jsx.res 43:11
 {"uri": "Component.res", "range": {"start": {"line": 1, "character": 4}, "end": {"line": 1, "character": 8}}}
 
 Complete tests/src/Jsx.res 52:2
-[]
+[{
+    "label": "align",
+    "kind": 4,
+    "tags": [],
+    "detail": "option<string>",
+    "documentation": null
+  }, {
+    "label": "key",
+    "kind": 4,
+    "tags": [],
+    "detail": "string",
+    "documentation": null
+  }]