Fix issue with duplication.

Fix #302

Author: cristianoc

analysis/src/ProcessCmt.ml

@@ -916,8 +916,8 @@ struct
            | Texp_open (_, _path, _ident, _) -> Hashtbl.add extra.opens eloc ()
            | _ -> ());
     match expression.exp_desc with
-    | Texp_ident (path, {txt; loc}, {val_type}) ->
-      addForLongident (Some (val_type, Value)) path txt loc
+    | Texp_ident (path, {txt; loc}, _) ->
+      addForLongident (Some (expression.exp_type, Value)) path txt loc
     | Texp_record {fields} ->
       addForRecord expression.exp_type
         (fields |> Array.to_list

analysis/tests/src/Hover.res

@@ -99,13 +99,13 @@ let withAs = (~xx as yyy) => yyy + 1
 
 module AA = {
   type cond<'a> = [< #str(string)] as 'a
-  let fun = (b: cond<_>) => true ? b : b
+  let fnnxx = (b: cond<_>) => true ? b : b
 }
 
-let funAlias = AA.fun
+let funAlias = AA.fnnxx
 
 let typeOk = funAlias
 //              ^hov
 
-let typeDuplicate = AA.fun
+let typeDuplicate = AA.fnnxx
 //                       ^hov

analysis/tests/src/expected/Fragment.res.txt

@@ -1,5 +1,5 @@
 Hover tests/src/Fragment.res 6:19
-{"contents": "```rescript\n{\"children\": 'children} => 'children\n```"}
+{"contents": "```rescript\nReact.component<{\"children\": React.element}>\n```\n\n```rescript\ntype component<'props> = componentLike<'props, element>\n```"}
 
 Hover tests/src/Fragment.res 9:56
 null

analysis/tests/src/expected/Hover.res.txt

@@ -47,10 +47,10 @@ Hover tests/src/Hover.res 75:7
 {"contents": "```rescript\nmodule A = {\n  let x: int\n}\n```"}
 
 Hover tests/src/Hover.res 85:10
-{"contents": "```rescript\n{\"children\": React.element} => React.element\n```"}
+{"contents": "```rescript\nReact.component<{\"children\": React.element}>\n```\n\n```rescript\ntype component<'props> = componentLike<'props, element>\n```"}
 
 Hover tests/src/Hover.res 88:10
-{"contents": "```rescript\n{\"children\": React.element} => React.element\n```"}
+{"contents": "```rescript\nReact.component<{\"children\": React.element}>\n```\n\n```rescript\ntype component<'props> = componentLike<'props, element>\n```"}
 
 Hover tests/src/Hover.res 93:25
 {"contents": "```rescript\nfloat\n```"}
@@ -62,5 +62,5 @@ Hover tests/src/Hover.res 106:16
 {"contents": "```rescript\nAA.cond<[< #str(string)]> => AA.cond<[< #str(string)]>\n```"}
 
 Hover tests/src/Hover.res 109:25
-{"contents": "```rescript\nAA.cond<\n  [< #str(string) & (string) & (string) & (string)],\n> => AA.cond<\n  [< #str(string) & (string) & (string) & (string)],\n>\n```"}
+{"contents": "```rescript\nAA.cond<[< #str(string)]> => AA.cond<[< #str(string)]>\n```"}