Add polyvar docs (latest) #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
reviewed
Jan 5, 2021
| ```res | ||
| // This doesn't actually need any color type definition | ||
| // beforehand | ||
| let myColor = #Red |
There was a problem hiding this comment.
Can we add the js output?
|
|
||
| ### Upper Bound (`[<`) | ||
|
|
||
| The upper bound works in the exact opposite way: The extending type may only use constructors that are stated in the lower bound constraint. |
There was a problem hiding this comment.
Suggested change
| The upper bound works in the exact opposite way: The extending type may only use constructors that are stated in the lower bound constraint. | |
| The upper bound works in the exact opposite way: the extending type may only use constructors that are stated in the lower bound constraint. |
bobzhang
reviewed
Jan 6, 2021
Content: - recursive types - JS output for relevant snippets - Variant vs polymorphic variant section
|
@bobzhang @IwanKaramazow @jchavarri thanks for your feedback! I addressed all your raised issues and actually added some more content that I forgot:
etc etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154