Refactor native video decoder for code reuse #7641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🚜 refactor
Wumpf
approved these changes
Oct 8, 2024
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
well threaded in 😁
We're starting to see a nice hierarchy of decoder wrangling logic. Let's hope we don't regret this and have to add holes through these nice abstractions, but so far I'm very optimistic on that!
| impl NativeDecoder { | ||
| pub fn new( | ||
| debug_name: String, | ||
| sync_decoder: Box<dyn re_video::decode::SyncDecoder + Send>, |
Member
There was a problem hiding this comment.
found it odd at first that all NativeDecoders host a SyncDecoder internally. But from the looks of it this gonna hold up at least for a a few weeks 😁 this is what we're dealing with :)
emilk
added a commit
that referenced
this pull request
Nov 26, 2025
Changes in snapshot images should be pixel-alignment improvements thanks to * emilk/egui#7710 --- ## egui changelog ### ⭐ Added * Add `Plugin::on_widget_under_pointer` to support widget inspector [#7652](emilk/egui#7652) by [@juancampa](https://github.com/juancampa) * Add `Response::total_drag_delta` and `PointerState::total_drag_delta` [#7708](emilk/egui#7708) by [@emilk](https://github.com/emilk) ### 🔧 Changed * Improve accessibility and testability of `ComboBox` [#7658](emilk/egui#7658) by [@lucasmerlin](https://github.com/lucasmerlin) ### 🐛 Fixed * Fix `profiling::scope` compile error when profiling using `tracing` backend [#7646](emilk/egui#7646) by [@PPakalns](https://github.com/PPakalns) * Fix edge cases in "smart aiming" in sliders [#7680](emilk/egui#7680) by [@emilk](https://github.com/emilk) * Hide scroll bars when dragging other things [#7689](emilk/egui#7689) by [@emilk](https://github.com/emilk) * Prevent widgets sometimes appearing to move relative to each other [#7710](emilk/egui#7710) by [@emilk](https://github.com/emilk) * Fix `ui.response().interact(Sense::click())` being flakey [#7713](emilk/egui#7713) by [@lucasmerlin](https://github.com/lucasmerlin) ## eframe changelog * Fix jittering during window resize on MacOS for WGPU/Metal [#7641](emilk/egui#7641) by [@aspcartman](https://github.com/aspcartman) * Make sure `native_pixels_per_point` is set during app creation [#7683](emilk/egui#7683) by [@emilk](https://github.com/emilk) --------- Co-authored-by: Lucas Meurer <lucasmeurer96@gmail.com> Co-authored-by: lucasmerlin <8009393+lucasmerlin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This refactors the native decoder so that we can easily slot in a different native decoder (ffmpeg!).
The innermost trait is now
SyncDecoderwhich gets pushed a chunk, and blocks while producing frames (or errors). Around that is anAsyncDecoderthat runs theSyncDecoderon a background thread to produce a non-blocking interface.Finally in
re_rendererthere is theNativeDecoderthat wrapsSyncDecoderand handles texture uploads.There is a lot of code moved, but very little code actually changed. It's just another layer of abstraction introduced.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.