Revert "Rename the Python SDK library from rerun_sdk
to just rerun
."
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30
Unfortunately this caused a name-clash where two Cargo targets share the same name:
Which sometimes leads to
error: failed to remove file
/Users/emilk/code/rerun/rerun/target/doc/rerun/index.html`.More info: rust-lang/cargo#6313
Hopefully we can work around this somehow. We could use a custom build directory, but that would lead to rebuilding the shared libraries twice, which isn't ideal. We could also just rename one of the targets after they have been built, which is a bit hacky but should work. In any case I don't feel it is the best use of my time to work on this right now, so for now the python library will have to remain as
rerun_sdk
.