Skip to content

Revert "Rename the Python SDK library from rerun_sdk to just rerun."#31

Merged
emilk merged 1 commit into
mainfrom
revert-30-rename-python-library
Aug 15, 2022
Merged

Revert "Rename the Python SDK library from rerun_sdk to just rerun."#31
emilk merged 1 commit into
mainfrom
revert-30-rename-python-library

Conversation

@emilk

@emilk emilk commented Aug 15, 2022

Copy link
Copy Markdown
Member

Reverts #30

Unfortunately this caused a name-clash where two Cargo targets share the same name:

> cargo doc --document-private-items --no-deps --all-features
warning: output filename collision.
The bin target `rerun` in package `rerun v0.1.0 (/Users/emilk/code/rerun/rerun/crates/rerun)` has the same output filename as the lib target `rerun` in package `re_sdk_python v0.1.0 (/Users/emilk/code/rerun/rerun/crates/re_sdk_python)`.
Colliding filename is: /Users/emilk/code/rerun/rerun/target/doc/rerun/index.html
The targets should have unique names.
This is a known bug where multiple crates with the same name use
the same path; see <https://github.com/rust-lang/cargo/issues/6313>.

Which sometimes leads to error: failed to remove file /Users/emilk/code/rerun/rerun/target/doc/rerun/index.html`.

More info: rust-lang/cargo#6313

Hopefully we can work around this somehow. We could use a custom build directory, but that would lead to rebuilding the shared libraries twice, which isn't ideal. We could also just rename one of the targets after they have been built, which is a bit hacky but should work. In any case I don't feel it is the best use of my time to work on this right now, so for now the python library will have to remain as rerun_sdk.

@emilk emilk merged commit 03d260f into main Aug 15, 2022
@emilk emilk deleted the revert-30-rename-python-library branch August 15, 2022 13:45
@linear linear Bot mentioned this pull request Nov 15, 2022
3 tasks
@emilk emilk mentioned this pull request Jan 24, 2023
rerun-sync Bot pushed a commit that referenced this pull request May 12, 2026
## Summary

Lockfile-only bumps plus a couple of pnpm `overrides` to close as many
open Dependabot security alerts as possible.

### Addressed (≈30 alerts)

**pip / uv:**
- `urllib3` → 2.7.0 (rerun, dataplatform — #260, #261, #252, #255)
- `gitpython` → 3.1.50 (rerun_export, dataloader — #248, #249, #228,
#229, #231, #232)
- `pygments` → 2.20.0 (rerun, dataplatform — #139, #140)
- `pynacl` → 1.6.2 (#24)
- `marshmallow` → 3.26.2 (#23)
- `filelock` → 3.29.0 (#21, #32)
- `virtualenv` → 21.3.1 (#31)
- `uv` → 0.11.13 (#170)
- `torch` → 2.11.0 in rerun/uv.lock (#43) — examples couldn't bump
(lerobot/diffusers chain)
- `flask` → 3.1.3 (#66)

**npm:**
- `fast-uri` → 3.1.2 (#240, #241)
- `postcss` → 8.5.14 (#199)
- `cookie` → 0.7.2 via `pnpm.overrides` in docs and landing (#87, #105)
— SvelteKit still pins 0.6 transitively

**cargo:**
- `rand` → 0.8.6 in rerun and dataplatform (#192, #193)

### Skipped

- **diffusers 0.38** (#226, #230, #233, #238) — pulls a `safetensors`
pre-release, see #1949
- **transformers 5.0.0rc3** (#163) — RC, intentionally not pulled
- **lru 0.16** (#19, #20) — pinned by `tantivy 0.24` (transitive via
`lance`)
- **thrift** (#239) — no patched version available
- **torch in examples** (#195, #196) — constrained by lerobot/diffusers
chain
- **pytest** (#208) — `rerun_py/pyproject.toml` already pins
`pytest==9.0.3`; alert is stale

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Source-Ref: ce3edfea8c4ea60c4c13bfef2ae235cd477384f3
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant