Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore slice-returns on compacted buckets breaks union components. #759

Closed
jleibs opened this issue Jan 13, 2023 · 2 comments
Closed
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working

Comments

@jleibs
Copy link
Member

jleibs commented Jan 13, 2023

When bringing up the arrow logging for image_files I noticed that objectron demo breaks down on bucket-splits.

The symptom is that images appear to stop updating, but the reality seems to be that all of the images in the bucket start receiving a single TensorData payload which is the concatenation of all the buckets.

Interestingly, see that the tensor-id values continue to change even while the binary payload stays fixed. so the implementation is at least partially working for some of the struct fields.

This feels like something is breaking in a nested slice -- very likely a bug in either arrow or arrow2-convert.

@jleibs jleibs added 🪳 bug Something isn't working 🏹 arrow concerning arrow labels Jan 13, 2023
@jleibs
Copy link
Member Author

jleibs commented Jan 13, 2023

After much digging I concluded this was an arrow2-convert problem. I should have searched the issues in the first place. Turns out this is a long-standing ticket upstream. DataEngineeringLabs/arrow2-convert#53

@jleibs jleibs changed the title Datastore corruption on image_files during bucket-split Datastore slice-returns on compacted buckets breaks union components. Jan 13, 2023
@jleibs
Copy link
Member Author

jleibs commented Jan 15, 2023

Turned out this was doubly broken.

@jleibs jleibs closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant