Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components should always delegate to a real datatype #5403

Open
jleibs opened this issue Mar 5, 2024 · 0 comments
Open

Components should always delegate to a real datatype #5403

jleibs opened this issue Mar 5, 2024 · 0 comments
Labels
codegen/idl enhancement New feature or request

Comments

@jleibs
Copy link
Member

jleibs commented Mar 5, 2024

For convenience, we currently allow components to be either:

  • An inlined primitive
  • A reference to a rerun datatype

Although this seemed like it would simplify creating components in cases, the net result is that components have to carry the complexity burden of both the potential to be a datatype as well as the ability to delegate through to another type.

This has resulted in plenty of code duplication, especially on the python serialization side, of re-implementing per-component support for primitives such as bool, when referencing a rerun.datatypes.bool would actually be easier.

By making all components always delegate to a concrete rerun datatype this also moves us a step in the direction of components being nothing more than a semantic label and a reference to one or more datatypes.

@jleibs jleibs added enhancement New feature or request codegen/idl labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant