Skip to content

Commit 8f0a252

Browse files
committed
Remove Float16 exceptions
1 parent 80f28c4 commit 8f0a252

File tree

1 file changed

+4
-40
lines changed
  • crates/store/re_types/tests/types

1 file changed

+4
-40
lines changed

crates/store/re_types/tests/types/fuzzy.rs

Lines changed: 4 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -238,16 +238,7 @@ fn roundtrip() {
238238
// NOTE: Keep those around please, very useful when debugging.
239239
// eprintln!("field = {field:#?}");
240240
// eprintln!("array = {array:#?}");
241-
if field.name() == "rerun.testing.components.AffixFuzzer21" {
242-
// TODO(#3741): Fields that contain Float16 apparently don't supported fmt
243-
// https://github.com/rerun-io/re_arrow2/blob/33a32000001df800e4840d92c33b03e7007311e1/src/array/primitive/fmt.rs#L39
244-
eprintln!(
245-
"{} = Can't be printed (float16 not supported)",
246-
field.name()
247-
);
248-
} else {
249-
eprintln!("{} = {array:#?}", field.name());
250-
}
241+
eprintln!("{} = {array:#?}", field.name());
251242
}
252243

253244
let deserialized = AffixFuzzer1::from_arrow(serialized).unwrap();
@@ -283,16 +274,7 @@ fn roundtrip() {
283274
// NOTE: Keep those around please, very useful when debugging.
284275
// eprintln!("field = {field:#?}");
285276
// eprintln!("array = {array:#?}");
286-
if field.name() == "rerun.testing.components.AffixFuzzer21" {
287-
// TODO(#3741): Fields that contain Float16 apparently don't supported fmt
288-
// https://github.com/rerun-io/re_arrow2/blob/33a32000001df800e4840d92c33b03e7007311e1/src/array/primitive/fmt.rs#L39
289-
eprintln!(
290-
"{} = Can't be printed (float16 not supported)",
291-
field.name()
292-
);
293-
} else {
294-
eprintln!("{} = {array:#?}", field.name());
295-
}
277+
eprintln!("{} = {array:#?}", field.name());
296278
}
297279

298280
let deserialized = AffixFuzzer2::from_arrow(serialized).unwrap();
@@ -319,16 +301,7 @@ fn roundtrip() {
319301
// NOTE: Keep those around please, very useful when debugging.
320302
// eprintln!("field = {field:#?}");
321303
// eprintln!("array = {array:#?}");
322-
if field.name() == "rerun.testing.components.AffixFuzzer21" {
323-
// TODO(#3741): Fields that contain Float16 apparently don't supported fmt
324-
// https://github.com/rerun-io/re_arrow2/blob/33a32000001df800e4840d92c33b03e7007311e1/src/array/primitive/fmt.rs#L39
325-
eprintln!(
326-
"{} = Can't be printed (float16 not supported)",
327-
field.name()
328-
);
329-
} else {
330-
eprintln!("{} = {array:#?}", field.name());
331-
}
304+
eprintln!("{} = {array:#?}", field.name());
332305
}
333306

334307
let deserialized = AffixFuzzer3::from_arrow(serialized).unwrap();
@@ -355,16 +328,7 @@ fn roundtrip() {
355328
// NOTE: Keep those around please, very useful when debugging.
356329
// eprintln!("field = {field:#?}");
357330
// eprintln!("array = {array:#?}");
358-
if field.name() == "rerun.testing.components.AffixFuzzer21" {
359-
// TODO(#3741): Fields that contain Float16 apparently don't supported fmt
360-
// https://github.com/rerun-io/re_arrow2/blob/33a32000001df800e4840d92c33b03e7007311e1/src/array/primitive/fmt.rs#L39
361-
eprintln!(
362-
"{} = Can't be printed (float16 not supported)",
363-
field.name()
364-
);
365-
} else {
366-
eprintln!("{} = {array:#?}", field.name());
367-
}
331+
eprintln!("{} = {array:#?}", field.name());
368332
}
369333

370334
let deserialized = AffixFuzzer4::from_arrow(serialized).unwrap();

0 commit comments

Comments
 (0)