Skip to content

Commit ffe4aa2

Browse files
committed
Update TODO doc strings with current status
1 parent 22e488f commit ffe4aa2

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/common/data_type.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub enum RexType {
5656
/// and manageable location. Therefore this structure exists
5757
/// to map those types and provide a simple place for developers
5858
/// to map types from one system to another.
59-
// TODO: This looks like this needs pyo3 tracking so leaving unfrozen for now
59+
// TODO: pyclass frozen
6060
#[derive(Debug, Clone)]
6161
#[pyclass(name = "DataTypeMap", module = "datafusion.common", subclass)]
6262
pub struct DataTypeMap {

src/common/schema.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ use crate::sql::logical::PyLogicalPlan;
3333

3434
use super::{data_type::DataTypeMap, function::SqlFunction};
3535

36-
// TODO I think the get/set prohibits frozen
36+
// TODO: pyclass frozen
3737
#[pyclass(name = "SqlSchema", module = "datafusion.common", subclass)]
3838
#[derive(Debug, Clone)]
3939
pub struct SqlSchema {
@@ -47,6 +47,7 @@ pub struct SqlSchema {
4747
pub functions: Vec<SqlFunction>,
4848
}
4949

50+
// TODO: pyclass frozen
5051
#[pyclass(name = "SqlTable", module = "datafusion.common", subclass)]
5152
#[derive(Debug, Clone)]
5253
pub struct SqlTable {
@@ -91,6 +92,7 @@ impl SqlTable {
9192
}
9293
}
9394

95+
// TODO: pyclass frozen
9496
#[pyclass(name = "SqlView", module = "datafusion.common", subclass)]
9597
#[derive(Debug, Clone)]
9698
pub struct SqlView {

src/expr/conditional_expr.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ use crate::{errors::PyDataFusionResult, expr::PyExpr};
1919
use datafusion::logical_expr::conditional_expressions::CaseBuilder;
2020
use pyo3::prelude::*;
2121

22-
// TODO: Can't make frozen because needs to mutate case_builder
22+
// TODO: pyclass frozen
23+
// Mutates CaseBuilder might need CaseBuilder derive clone upstream
24+
// since when basically clones
2325
#[pyclass(name = "CaseBuilder", module = "datafusion.expr", subclass)]
2426
pub struct PyCaseBuilder {
2527
pub case_builder: CaseBuilder,

0 commit comments

Comments
 (0)