Skip to content

Commit 6b8f87c

Browse files
committed
updates unit tests, pending one last test to assert warning message is printed to console when in default mode
1 parent 33d5bb5 commit 6b8f87c

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

tests/test_log_filters.py

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,30 @@
66
class TestDebugModeTokenFilter(unittest.TestCase):
77

88
def setUp(self):
9-
self.record = logging.LogRecord(name="test", level=logging.DEBUG, pathname=None, lineno=None, msg="Bearer i-am-a-little-token-here-is-my-scope-and-here-is-my-signature", args=None, exc_info=None)
9+
self.record = logging.LogRecord(name="test", level=logging.DEBUG, pathname=None, lineno=None, msg="Bearer i-am-a-little-token-here-is-my-scope-and-here-is-my-hash", args=None, exc_info=None)
1010

11-
@patch.dict('os.environ', {'DEBUG_MODE_TOKEN_FILTER': 'MASK'})
11+
@patch.dict('os.environ', {'REQUESTS_OAUTHLIB_DEBUG_MODE_TOKEN_FILTER': 'MASK'})
1212
def test_mask_mode(self):
1313
filter = DebugModeTokenFilter()
1414
filter.filter(self.record)
1515
self.assertIn('[MASKED]', self.record.msg)
1616

17-
@patch.dict('os.environ', {'DEBUG_MODE_TOKEN_FILTER': 'SUPPRESS'})
17+
@patch.dict('os.environ', {'REQUESTS_OAUTHLIB_DEBUG_MODE_TOKEN_FILTER': 'SUPPRESS'})
1818
def test_suppress_mode(self):
1919
filter = DebugModeTokenFilter()
20-
result = filter.filter(self.record)
21-
self.assertFalse(result) # No logging
20+
filter.filter(self.record)
21+
self.assertEqual(" ", self.record.msg) # No logging
22+
23+
# @patch.dict('os.environ', {'REQUESTS_OAUTHLIB_DEBUG_MODE_TOKEN_FILTER': 'DEFAULT'})
24+
# def test_default_mode_raises_warning(self):
25+
# with self.assertLogs('requests_oauthlib', level='WARN') as cm:
26+
# DebugModeTokenFilter()
27+
# logging.getLogger("requests_oauthlib").addFilter(DebugModeTokenFilter())
28+
# # Trigger the log event to check for the warning message
29+
# logging.getLogger("requests_oauthlib").debug(self.record.getMessage())
30+
31+
# self.assertIn("Your logger, when in DEBUG mode, will log TOKENS", cm.output[0])
2232

23-
@patch.dict('os.environ', {'DEBUG_MODE_TOKEN_FILTER': 'DEFAULT'})
24-
def test_default_mode_raises_warning(self):
25-
filter = DebugModeTokenFilter()
26-
result = filter.filter(self.record)
27-
self.assertTrue(result)
2833

2934
if __name__ == '__main__':
3035
unittest.main()

0 commit comments

Comments
 (0)