Skip to content

Use any-promise? #71

@knpwrs

Description

@knpwrs

Do you think it would make sense to use any-promise for this library? While I personally *love Bluebird, I don't see any Bluebird-specific functionality being used and this would allow for people to pick their own Promise library (or go native).

I noticed that bluebird-cls is included as a dependency, but continuation-local-storage is a dev dependency. Maybe, if this library were to go the route of using any-promise, it would make sense to move bluebird and bluebird-cls to devDependencies for testing purposes and then either move the require of bluebird-cls to a test or gate it off using process.env.NODE_ENV !== "production" so it could be trimmed out with something like Envify.

Open to hearing your thoughts.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions