Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add agent.destroy #30

Open
vvo opened this issue Apr 20, 2015 · 2 comments
Open

add agent.destroy #30

vvo opened this issue Apr 20, 2015 · 2 comments

Comments

@vvo
Copy link

vvo commented Apr 20, 2015

To close all remaining free sockets, thoughts @simov?

@simov
Copy link
Member

simov commented Apr 21, 2015

Sounds logical, I guess you are referring to the code used in this test request/request#1511 (comment)

If you are going to implement that method here, we're also going to need a failing test in the request repository, as we don't have any tests here.

@andrew-aladev
Copy link

andrew-aladev commented Nov 7, 2016

We've fixed this issue in this fork. Should we provide a pull request?

PS Original forever agent has an issue with.

  if (this.sockets[name]) {
    ...
  } else if (this.sockets[name] && this.sockets[name].length === 0) {
    ...
  }

else won't be invoked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants