destination folder section #4747

DmytroChebakov2191 · 2025-11-24T16:02:40Z

PR Checklist

Visuals

coderabbitai · 2025-11-24T16:02:59Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/import-modal-destination-folder-selection

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov-commenter · 2025-11-24T16:15:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (aba368f) to head (396f973).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           feature/test-library    #4747   +/-   ##
=====================================================
  Coverage                 72.59%   72.59%           
=====================================================
  Files                        79       79           
  Lines                       905      905           
  Branches                    124      124           
=====================================================
  Hits                        657      657           
  Misses                      224      224           
  Partials                     24       24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ViktorSoroka07 · 2025-11-24T16:59:38Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

+import { Folder, foldersSelector } from 'controllers/testCase';
+import { useImportTestCase } from './useImportTestCase';


Suggested change

import { Folder, foldersSelector } from 'controllers/testCase';

import { useImportTestCase } from './useImportTestCase';

import { Folder, foldersSelector } from 'controllers/testCase';

import { useImportTestCase } from './useImportTestCase';

ViktorSoroka07 · 2025-11-24T17:00:54Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

    dispatch(hideModalAction());
  };

+  const setTargetAndForm = (next: 'root' | 'existing') => {


Let's create type for 'root' | 'existing' union and use here and in useState above

ViktorSoroka07 · 2025-11-24T17:01:17Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

+  useEffect(() => {
+    change('importTarget', target);
+
+    if (folderIdFromUrl && existingOptions.some((o) => Number(o.value) === folderIdFromUrl)) {


Suggested change

if (folderIdFromUrl && existingOptions.some((o) => Number(o.value) === folderIdFromUrl)) {

if (folderIdFromUrl && existingOptions.some((option) => Number(option.value) === folderIdFromUrl)) {

Suggested change

if (folderIdFromUrl && existingOptions.some((o) => Number(o.value) === folderIdFromUrl)) {

if (folderIdFromUrl && existingOptions.some(({ value }) => Number(value) === folderIdFromUrl)) {

ViktorSoroka07 · 2025-11-24T17:01:45Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

+
+  const isWithinSize = (file: File) => file.size <= MAX_FILE_SIZE_BYTES;
+
+  const hasExistingOptions = existingOptions.length > 0;


Suggested change

const hasExistingOptions = existingOptions.length > 0;

const hasExistingOptions = !isEmpty(existingOptions);

ViktorSoroka07 · 2025-11-24T17:04:23Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/useImportTestCase.ts

+} from 'controllers/testCase/actionCreators';
+import { getTestCaseRequestParams } from 'pages/inside/testCaseLibraryPage/utils';
+import { testCasesPageSelector } from 'controllers/testCase';
+import { useCallback } from 'react';


Order of imports

OleksandrDragun · 2025-11-24T18:30:18Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.scss

+  &__segmented {
+    display: flex;
+    gap: 4px;
+    background: $COLOR--bg-200;


Suggested change

background: $COLOR--bg-200;

background: var(--rp-ui-base-bg-200);

OleksandrDragun · 2025-11-24T18:33:08Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

 }: InjectedFormProps<ImportTestCaseFormValues, ImportModalData> & ImportModalData) => {
  const { formatMessage } = useIntl();
  const [file, setFile] = useState<File | null>(null);
  const [folderIdFromUrl] = useState<number | undefined>(() =>


Why do not we have set action here?

OleksandrDragun · 2025-11-24T18:37:39Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

+    if (importTarget === 'existing') {
+      const resolvedId = existingFolderId ?? folderIdFromUrl;
+
+      if (!file || resolvedId == null) return;


Could you please add an empty line after if here and below.

OleksandrDragun · 2025-11-24T18:42:50Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

+                  className={cx(
+                    'import-test-case-modal__segmented-btn',
+                    target === 'root' && 'is-active',
+                  )}


Suggested change

className={cx(

'import-test-case-modal__segmented-btn',

target === 'root' && 'is-active',

)}

className={cx('import-test-case-modal__segmented-btn', {

'is-active': target === 'root'

})}

Also you can create const isRootTarget and reuse it here and for target === 'existing' as !isRootTarget.

OleksandrDragun · 2025-11-24T18:45:29Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/importTestCaseModal.tsx

-      folderName: commonValidators.requiredField(folderName),
-    }),
+    initialValues: { folderName: DEFAULT_FOLDER_NAME, importTarget: undefined },
+    validate: (values): FormErrors<ImportTestCaseFormValues> => {


Suggested change

validate: (values): FormErrors<ImportTestCaseFormValues> => {

validate: ({ importTarget, folderName }): FormErrors<ImportTestCaseFormValues> => {

OleksandrDragun · 2025-11-24T18:46:54Z

app/src/pages/inside/testCaseLibraryPage/importTestCaseModal/messages.ts

    defaultMessage: 'File size should be up to {size} MB',
  },
+  specifyLocation: {
+    id: 'import.specifyLocation',


Suggested change

id: 'import.specifyLocation',

id: 'ImportTestCaseModal.specifyLocation',

And below. Could you please use the full path in the id as a key (not just createRoot but createNewRootFolder)

ViktorSoroka07 · 2025-11-28T14:53:10Z

Please add visuals

…tion-folder-selection

sonarqubecloud · 2025-11-28T15:58:27Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DmytroChebakov2191 requested review from AmsterGet, allaprischepa and maria-hambardzumian as code owners November 24, 2025 16:02

DmytroChebakov2191 added the TMS label Nov 24, 2025

DmytroChebakov2191 requested review from OleksandrDragun, ViktorSoroka07 and yelyzavetakhokhlova and removed request for AmsterGet, allaprischepa and maria-hambardzumian November 24, 2025 16:03

ViktorSoroka07 reviewed Nov 24, 2025

View reviewed changes

OleksandrDragun reviewed Nov 24, 2025

View reviewed changes

DmytroChebakov added 3 commits November 27, 2025 16:24

destination folder section

ce4b5f5

destination folder section

ba82662

fix some comments

4ec385d

fix some comments

c5bf0c5

DmytroChebakov2191 force-pushed the feature/import-modal-destination-folder-selection branch from 517a536 to c5bf0c5 Compare November 28, 2025 15:57

Merge branch 'feature/test-library' into feature/import-modal-destina…

396f973

…tion-folder-selection

		import { Folder, foldersSelector } from 'controllers/testCase';
		import { useImportTestCase } from './useImportTestCase';

	if (folderIdFromUrl && existingOptions.some((o) => Number(o.value) === folderIdFromUrl)) {
	if (folderIdFromUrl && existingOptions.some((option) => Number(option.value) === folderIdFromUrl)) {


		const isWithinSize = (file: File) => file.size <= MAX_FILE_SIZE_BYTES;

		const hasExistingOptions = existingOptions.length > 0;

	const hasExistingOptions = existingOptions.length > 0;
	const hasExistingOptions = !isEmpty(existingOptions);

	background: $COLOR--bg-200;
	background: var(--rp-ui-base-bg-200);

	validate: (values): FormErrors<ImportTestCaseFormValues> => {
	validate: ({ importTarget, folderName }): FormErrors<ImportTestCaseFormValues> => {

	id: 'import.specifyLocation',
	id: 'ImportTestCaseModal.specifyLocation',

destination folder section #4747

Are you sure you want to change the base?

destination folder section #4747

Uh oh!

Conversation

DmytroChebakov2191 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Visuals

Uh oh!

coderabbitai bot commented Nov 24, 2025

Review skipped

Uh oh!

codecov-commenter commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OleksandrDragun Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ViktorSoroka07 commented Nov 28, 2025

Uh oh!

sonarqubecloud bot commented Nov 28, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DmytroChebakov2191 commented Nov 24, 2025 •

edited

Loading

codecov-commenter commented Nov 24, 2025 •

edited

Loading

OleksandrDragun Nov 24, 2025 •

edited

Loading