Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning if a webpack query matches more than one module #525

Open
asportnoy opened this issue Aug 3, 2023 · 0 comments
Open

Log a warning if a webpack query matches more than one module #525

asportnoy opened this issue Aug 3, 2023 · 0 comments
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! enhancement New feature or request good first issue Good for newcomers

Comments

@asportnoy
Copy link
Member

If a webpack query (ie props of source) matches more than one module, it is not a very reliable query and could break if load order changes or if one of the modules gets changed. We should log a warning to the console if a selector matches more than one module (without all enabled) to encourage devs to improve their module selectors.

@asportnoy asportnoy added enhancement New feature or request good first issue Good for newcomers available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant