Skip to content

Modernize Python package infrastructure #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 11, 2023
Merged

Modernize Python package infrastructure #84

merged 7 commits into from
Apr 11, 2023

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Apr 7, 2023

Depends on #83

This PR adopts current best practices for Python libraries by replacing setup.py with pyproject.toml, writing resolved dependencies to requirements.txt files using pip-compile.

@mattt mattt mentioned this pull request Apr 7, 2023
Merged
zeke
zeke approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no authority on Python best practices, but this looks good to me. 👍🏼

mattt added 7 commits April 11, 2023 15:23
@mattt
Replace setup.py with pyproject.toml
9360500 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Set requires-python >= 3.8
94e6f64 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Generate requirements files from pyproject.toml using pip-tools
546b3f0 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Replace pytest.ini with pyproject.toml entry
f743e21 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Define canonical version in pyproject.toml
90f4629 
Set __version__ dynamically

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Update CI workflow
bbfa7b2 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Update dev dependencies
6d0d0cf 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt mattt force-pushed the mattt/pyproject branch from 78b79e2 to 6d0d0cf Compare April 11, 2023 22:23
@mattt mattt merged commit 6094f5a into main Apr 11, 2023
@mattt mattt deleted the mattt/pyproject branch April 11, 2023 22:24
@mattt mattt mentioned this pull request May 1, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeke zeke zeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattt @zeke