Skip to content

Add async_wait method to Prediction class #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2024
Merged

Add async_wait method to Prediction class #225

merged 5 commits into from
Jan 23, 2024

Conversation

nurikk
Copy link
Contributor

@nurikk nurikk commented Jan 7, 2024

Use non blocking wait function

@nurikk-sa @nurikk
Add async_wait method to Prediction class
65a3e7e 
Signed-off-by: John Doe <nurikk@users.noreply.github.com>
nurikk added 2 commits January 14, 2024 11:04
@nurikk
Refactor Prediction class to use async/await for reloading
2c69f34 
Signed-off-by: John Doe <nurikk@users.noreply.github.com>
@nurikk
Refactor async_get method call in run.py
439ccae 
Signed-off-by: John Doe <nurikk@users.noreply.github.com>
mattt
mattt approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening this PR, @nurikk. Everything is looking great. Merging this now and cutting a new minor release.

@mattt mattt merged commit 950ba0f into replicate:main Jan 23, 2024
@mattt
Copy link
Contributor

mattt commented Jan 23, 2024 •
edited
Loading

Thanks again for your contribution, @nurikk! This is now live in 0.23.0.

@rohan-mehta rohan-mehta mentioned this pull request Jan 23, 2024
Closed
GothReigen pushed a commit that referenced this pull request Feb 9, 2024
@nurikk @nurikk-sa
@mattt @GothReigen
Add async_wait method to Prediction class (#225)
dc2249a 
Use non blocking wait function

---------

Signed-off-by: John Doe <nurikk@users.noreply.github.com>
Co-authored-by: Ainur Timerbaev <ainur.timerbaev@superawesome.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
GothReigen pushed a commit that referenced this pull request Mar 11, 2024
@nurikk @nurikk-sa
@mattt @GothReigen
Add async_wait method to Prediction class (#225)
296180a 
Use non blocking wait function

---------

Signed-off-by: John Doe <nurikk@users.noreply.github.com>
Co-authored-by: Ainur Timerbaev <ainur.timerbaev@superawesome.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattt mattt mattt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nurikk @mattt @nurikk-sa