Skip to content

Add missing typing_extensions dependency #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

evilstreak
Copy link
Contributor

We're relying on a feature (deprecated) from version 4.5.0 of typing_extensions, but the version bundled with Python varies. Include it as an explicit dependency to avoid import errors for users.

@evilstreak evilstreak requested a review from mattt November 16, 2023 17:26
We're relying on a feature (`deprecated`) from version 4.5.0 of
typing_extensions, but the version bundled with Python varies. Include
it as an explicit dependency to avoid import errors for users.

Signed-off-by: Dominic Baggott <dominic.baggott@gmail.com>
@evilstreak evilstreak force-pushed the add-missing-dependency branch from 459770b to f779345 Compare November 16, 2023 17:26
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evilstreak!

@mattt mattt merged commit 8002518 into main Nov 17, 2023
@mattt mattt deleted the add-missing-dependency branch November 17, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants