Skip to content

[async] Include prediction id upload request #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[async] Include prediction id upload request #1680

wants to merge 1 commit into from

Conversation

technillogue
Copy link
Contributor

@technillogue technillogue commented May 21, 2024 •
edited
Loading

httpx version of #1667

We now allow downstream services to include the destination of the asset in a Location header, rather than assuming that it's the same as the final upload url (either the one passed via --upload-url or the result of a 307 redirect response.
We now include the X-Prediction-Id header in upload request, this allows the downstream client to potentially do configuration/routing based on the prediction ID. This ID should be considered unsafe and needs to be validated by the downstream service.

@technillogue technillogue changed the base branch from main to async May 21, 2024 02:42
@technillogue technillogue changed the title 1. We now allow downstream services to include the destination of the asset in a Location header, rather than assuming that it's the same as the final upload url (either the one passed via --upload-url or the result of a 307 redirect response. [async] Include prediction id upload request May 21, 2024
@technillogue technillogue requested a review from evilstreak May 21, 2024 02:43
@technillogue
set X-Prediction-ID when uploading files and read Location for final url
c73fd5a 
1. We now allow downstream services to include the destination of the asset in a `Location` header, rather than assuming that it's the same as the final upload url (either the one passed via `--upload-url` or the result of a 307 redirect response.
2. We now include the `X-Prediction-Id` header in upload request, this allows the downstream client to potentially do configuration/routing based on the prediction ID.

Signed-off-by: technillogue <technillogue@gmail.com>
@technillogue technillogue force-pushed the syl/upload-header-x-prediction-id-async branch from 09cf3a4 to c73fd5a Compare May 21, 2024 02:45
@technillogue technillogue requested a review from aron May 22, 2024 05:53
@aron
Copy link
Contributor

aron commented Jul 4, 2024

I opened #1788 in place of this one. Not because there was anything wrong with this code, I just found it useful to re-implement the PR to get my head around the async branch.

@aron aron closed this Jul 4, 2024
@nickstenning nickstenning deleted the syl/upload-header-x-prediction-id-async branch February 11, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilstreak evilstreak Awaiting requested review from evilstreak

@aron aron Awaiting requested review from aron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technillogue @aron