feat(manager/flux): support chartRef in HelmRelease resources #31962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Oct 16, 2024
viceice
reviewed
Oct 16, 2024
| @@ -0,0 +1,14 @@ | |||
| apiVersion: source.toolkit.fluxcd.io/v1 | |||
There was a problem hiding this comment.
can you join both fixtures and inline them to test? or will it cause code coverage issues?
There was a problem hiding this comment.
could be also inlined in most tests, but they are also used in one test for extractAllPackageFiles, where file paths are currently expected in the results (https://github.com/renovatebot/renovate/pull/31962/files#diff-e4fcec4565b58234272751cf6a22e089c6e13b651bb297b4db19834442b124e1R960-R961).
quick search shows that this seems to be related to #19056, similar situation as in the referenced discussion/comments there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for
chartReffields withinHelmReleaseresources in the flux manager, as described in #31945.Context
Closes #31945
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: