Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign GitLab MRs on creation and not as update #9252

Open
fzoske opened this issue Mar 23, 2021 · 4 comments
Open

Assign GitLab MRs on creation and not as update #9252

fzoske opened this issue Mar 23, 2021 · 4 comments
Labels
platform:gitlab GitLab Platform priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@fzoske
Copy link
Contributor

fzoske commented Mar 23, 2021

What would you like Renovate to be able to do?
Assign the MRs in GitLab directly to one of the assinees on creation instead of updating the MR.

In the emails generetad by GitLab currently only contain: "Assignee changed to " but it would be great to have the description of the MR in the mail as well.

Best regards,
Fabian

@fzoske fzoske added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Mar 23, 2021
@HonkingGoose HonkingGoose added platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Mar 23, 2021
@viceice
Copy link
Member

viceice commented Mar 23, 2021

This would need a general refactoring, as renovate currently don't assign any reviewers (beside some platform defaults) to any pr.

@fzoske
Copy link
Contributor Author

fzoske commented Mar 23, 2021

@viceice But renovate currently assigns the prs to the configured assignees, but at a later point.

@viceice
Copy link
Member

viceice commented Mar 23, 2021

@fzoske Yes, it's a completly separate function for all renovate supported platforms

addReviewers(number: number, reviewers: string[]): Promise<void>;

@rarkins
Copy link
Collaborator

rarkins commented Mar 23, 2021

I don't have any objection to assigning at the time of creation and saving an API call while we're at it, but we need to work out how to do that elegantly so that platforms which don't support it in an extra operation can do so. e.g. maybe pass assignees and reviewers to the createPr function in platform and let the platform decide whether it can add them directly with the PR creation or do a second query after.

@rarkins rarkins added status:ready priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gitlab GitLab Platform priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants