Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab: Skip author filtering when group or project tokens are in use #28997

Open
rarkins opened this issue May 11, 2024 · 0 comments
Open

GitLab: Skip author filtering when group or project tokens are in use #28997

rarkins opened this issue May 11, 2024 · 0 comments
Labels
platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2024

Describe the proposed change(s).

Migrate ignorePrAuthor to platformAuthorFilter. Default value should be auto and with possible options auto, enabled, disabled.

For GitLab, when platformAuthorFilter=auto then it should set that to disabled if the bot username starts with group_ or project_. i.e. download all Issues and MRs if such a token is in use.

Otherwise platformAuthorFilter=auto should default to enabled, including for other GitLab token types plus other platforms. i.e. retain same behavior as today.

Migrate:

  • ignorePrAuthor=true to platformAuthorFilter=disabled
  • (explicitly configured) ignorePrAuthor=false to platformAuthorFilter=enabled
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others platform:gitlab GitLab Platform labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant