-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm i --package-lock-only
breaks lockfile when file: references present
#2388
Comments
@martijnwalraven I have added an option to perform a full |
Thanks for looking at this, and for building in the work-around, @rarkins. Can we go ahead and enable |
I’ve enabled it already for your repo so no need for extra config on the repo. Any PR that’s created or rebased from now on should have a correct lockfile attached. |
@rarkins We're about to merge similar file reference changes into Apollo Client (see apollographql/apollo-client#3817). Any chance we could also have |
Yes, I can do that. I’m thinking of making it automatic for any repo that has file: dependencies too |
That would be awesome! We're switching to using file references in a few other repos shortly, so that would really help. Thanks! |
I’ve now switched on full installs any time a “file:” dependency is included with |
Ouch, I bet the workload just shot up 🙁. Thanks for jumping on this so quickly @rarkins! |
As mentioned in #2294, the
package-lock.json
we're creating is wrong sometimes, seemingly due to a bug innpm
.npm reference: https://npm.community/t/npm-i-package-lock-only-changes-lock-file-incorrectly-when-file-references-used-in-dependencies/1412
For now, the only workaround is to fully install node_modules.
The text was updated successfully, but these errors were encountered: