Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Renovate image appears to include expired CA for Let's Encrypt certificates #235

Closed
epowell opened this issue Sep 30, 2021 · 11 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@epowell
Copy link

epowell commented Sep 30, 2021

Context on CA expiration: https://techcrunch.com/2021/09/21/lets-encrypt-root-expiry/

The renovate/renovate image, as used by a renovate-runner instance in our local Gitlab installation, is currently experiencing errors like this when accessing any repository, starting at ~9AM CDT 9/30/2021:

"message": "fatal: unable to access 'https://git.example.com/path/to/repository.git/': server certificate verification failed. CAfile: none CRLfile: none",
             "stack": "Error: fatal: unable to access 'https://git.example.com/path/to/repository.git/': server certificate verification failed. CAfile: none CRLfile: none
    at Object.action (/usr/src/app/node_modules/simple-git/src/lib/plugins/error-detection.plugin.ts:38:28)
    at PluginStore.exec (/usr/src/app/node_modules/simple-git/src/lib/plugins/plugin-store.ts:24:29)
    at /usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:114:40
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:111:14)
    at GitExecutorChain.<anonymous> (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:88:40)
    at Generator.next (<anonymous>)
    at fulfilled (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)"

Our Gitlab installation uses a Let's Encrypt issued certificate, rooted in the new "ISRG Root X1" CA that is valid until 2035. Our current server cert is valid until 29 Nov 2021. Inspecting this cert in an up-to-date browser (both Chrome and Firefox) shows a valid certificate and trust chain.

This leads me to conclude that the trusted CAs inside the renovate/renovate image need to update to include an updated list of trusted CAs, including the newer ISRG Root X1 root CA.

@viceice
Copy link
Member

viceice commented Sep 30, 2021

Which version of the image are you using?

@viceice
Copy link
Member

viceice commented Sep 30, 2021

@rarkins seeing this too now at my bot. 😱

Node is working fine, but git checkout fails.
So i assume something is wrong in Ubuntu image.

Will try to fix later today. 😕

@rarkins
Copy link
Contributor

rarkins commented Sep 30, 2021

@rarkins
Copy link
Contributor

rarkins commented Sep 30, 2021

@rarkins
Copy link
Contributor

rarkins commented Sep 30, 2021

https://community.letsencrypt.org/t/production-chain-changes/150739

But I still don't understand why we're affected. Neither Ubuntu or git are old

@epowell
Copy link
Author

epowell commented Sep 30, 2021

Current image on my install is: renovate/renovate:27.21.0@sha256:c83b8ebf3ca994b04c5a135d03bd5aa3cb813e005f1a0f22b633d8f1d648c2c1

No pending updates from upstream (per Renovate itself anyway :) )

@rarkins
Copy link
Contributor

rarkins commented Sep 30, 2021

@viceice can we add this?

sed -i"" 's/mozilla\/DST_Root_CA_X3.crt/!mozilla\/DST_Root_CA_X3.crt/' /etc/ca-certificates.conf
dpkg-reconfigure -fnoninteractive ca-certificates
update-ca-certificates

@viceice
Copy link
Member

viceice commented Sep 30, 2021

The issue should be fixed with next base image update in next two or three hours.

Maybe you need to manually update to latest docker digest.

@viceice
Copy link
Member

viceice commented Oct 1, 2021

Latest images are working again

@viceice viceice closed this as completed Oct 1, 2021
@epowell
Copy link
Author

epowell commented Oct 1, 2021

Confirmed working with the latest 0.27.25 image on my infrastructure. Thank you for your extremely fast response and diligent work to fix this!

@rarkins
Copy link
Contributor

rarkins commented Oct 1, 2021

Special thanks to @viceice for fixing it late at night while on vacation!

@viceice viceice unpinned this issue Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants