-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodetected benchmark parameters should be reported in output #203
Comments
Do you mean the textual output, or the JSON output file? I was already thinking about making it possible for the writer to dump the actual configuration of a benchmark. The reason why I haven't done that yet is that I will need to change the plugin API to provide access to this information. It would be easy to just expose the BenchmarkInfo object in the event notification, but to make it smooth, I would probably want to move the Plugin and the ExecutionPolicy classess into the harness package, so as to move the API for benchmark writers and plugin writers to separate packages. I'll try to put this into the next API update -- these are the exact reasons I was waiting for to do something :-) |
Perhaps we could additionally add a -v flag to enable verbose output that shows information such as this on stdout. |
For me the JSON output makes most sense, because that will document how the measurements were obtained, but I can imagine other use cases where one would want to see the value of the options on a console without executing the workload. |
JSON sounds good to me then. |
Adding it to JSON is good. Other suites do that (here dacapo) :
|
When a benchmark autodetects a parameter (such as thread_count=$cpu.count), the actual value used should be reported in the benchmark output.
The text was updated successfully, but these errors were encountered: