-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types are missing ignore option #2223
Comments
I'm not a TS dev, so won't really know, off the top of my head, how this should be done. Assume it's not covered the existing types file? |
Hi @remy,
Exactly. export interface NodemonConfig {
/* restartable defaults to "rs" as a string the user enters */
restartable?: false | String;
colours?: Boolean;
execMap?: { [key: string]: string };
ignoreRoot?: string[];
watch?: string[];
stdin?: boolean;
runOnChangeOnly?: boolean;
verbose?: boolean;
signal?: string;
stdout?: boolean;
watchOptions?: WatchOptions;
} Simply adding a line to the structure like this should do the trick export interface NodemonConfig {
...
ignore?: string[];
...
} |
Would you accept a PR for this? |
Happy to take a PR, or I should be able to get it up today asit looks like a single line - but you might be in a better position to test it works the way you'd expect. |
Sure, I added this small fix. This does the trick as TypeScript now knows about the |
The defined types are missing the
ignore
options so typescript complains about ithttps://github.com/remy/nodemon/blob/main/index.d.ts#L105-L118
Expected behaviour
The types should include
ignore
The text was updated successfully, but these errors were encountered: