-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodemon do not kill older process. #1435
Comments
Saldy, same for me. EDIT: |
Also happening here: I'm not on I'm not sure if nodemon is attempting to restart before the PID kill has completed, but in my tests it looked like that might be the case. I checked the PID before a restart and had the app log out the PID when |
I also have this issue Nodemon v1.18.4 |
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
Same issue with |
Um…no one has actually provided an app.js to replicate with. Without that, it can't be replicated and can't be debugged. |
I have this example set up - https://codesandbox.io/s/o4wzoqk9o6 Tried running in both my default environment and with the sandbox versions. Both fail. Mac OS 10.13.6 - shell: zsh 5.3 (x86_64-apple-darwin17.0) |
Same problem here. (not expected): If you modify server index.js, save it you will get a mentioned above error. And event not captured :( Environment: Linux, Node 8.11.4 |
I tried multiple things thinking it might of been my environment but I am seeing the same thing even after a clean ubuntu 18.04 install. Getting EADDRINUSE 127.0.0.1:1337 on file change. (Ctrl+C and restart works).
Can't get it to update on change without crashing. |
Fairly sure this is directly related to #1459 et al. nodemon@1.18.7 fixes it. Please test with latest (currently being released) and let me know if it's not fixed (and please include tests and PR to contribute). |
Working for me. Thanks !!!! |
Just to confirm that 1.18.7 indeed fixed the problem for me. Thanks. |
Working too. Thanks |
Version 1.19.0 still not exiting correctly |
Having the same problem with version 1.19.4 app.listen(PORT, () => { |
I figured out that after code change not only node process still running, but the parent nodemon process too. Try killing both nodemon parent and node proccesses and rerun nodemon. For now it helped me, but it happened not first time. |
same here in v2.0.4 |
nodemon -v
: 1.18.4node -v
: 8.12.0Expected behaviour
When I make some changes to the code, the expected behaviour is that the node will kill the node process and create a new one.
Actual behaviour
nodemon creates a new process but does not kill the old process and because of this, I have a conflict between ports.
Steps to reproduce
$ nodemon app
Error Message:
*This is the first time I write an issue. Forgive me if any information was missing.
The text was updated successfully, but these errors were encountered: