fix: rs in node@11 (#1493)

Fixes node 11's `rs` support. Somehow required that the `process.stdin` to be disconnected from the child before the stream is resumed (whereas previously it seemed that it would automatically happen…possibly a node 11 bug). Fixes #1493
remy · Dec 14, 2018 · dd0b96a · dd0b96a
1 parent 3dfd5cc
commit dd0b96a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,7 +5,8 @@ cache:
 notifications:
   email: false
 node_js:
-  - '9'
+  - '11'
+  - '10'
   - '8'
   - '6'
   - '4'

diff --git a/lib/monitor/run.js b/lib/monitor/run.js
@@ -151,6 +151,10 @@ function run(options) {
   });
 
   child.on('exit', function (code, signal) {
+    if (child && child.stdin) {
+      process.stdin.unpipe(child.stdin);
+    }
+
     if (code === 127) {
       utils.log.error('failed to start process, "' + cmd.executable +
         '" exec not found');

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "debug": "^3.1.0",
     "ignore-by-default": "^1.0.1",
     "minimatch": "^3.0.4",
-    "pstree.remy": "^1.1.3",
+    "pstree.remy": "^1.1.6",
     "semver": "^5.5.0",
     "supports-color": "^5.2.0",
     "touch": "^3.1.0",