Merge pull request #5316 from remotion-dev/dont-copy-if-videocodec-is-explicit

Author: JonnyBurger

packages/convert/app/components/get-supported-configs.tsx

@@ -113,6 +113,7 @@ export const getSupportedConfigs = async ({
 			rotationToApply: userRotation,
 			inputContainer,
 			resizeOperation,
+			outputVideoCodec: null,
 		});
 		if (canCopy && prioritizeCopyOverReencode) {
 			options.push({
@@ -161,6 +162,7 @@ export const getSupportedConfigs = async ({
 			inputCodec: track.codecEnum,
 			outputContainer: container,
 			inputContainer,
+			outputAudioCodec: null,
 		});
 
 		if (canCopy) {

packages/docs/docs/webcodecs/can-copy-audio-track.mdx

@@ -37,6 +37,7 @@ for (const track of audioTracks) {
     inputCodec: track.codecEnum,
     outputContainer: 'webm',
     inputContainer: container,
+    outputAudioCodec: null
   }); // bool
 }
 ```
@@ -86,6 +87,12 @@ _string_ <TsType type="ConvertMediaContainer" source="@remotion/webcodecs" />
 
 The container format of the output media.
 
+### `outputAudioCodec`
+
+_string | null_ <TsType type="ConvertMediaAudioCodec" source="@remotion/webcodecs" />
+
+The desired audio codec of the output media. If `null`, it means you don't care about the audio codec as long as it can be copied.
+
 ## Return value
 
 Returns a `boolean`.

packages/docs/docs/webcodecs/can-copy-video-track.mdx

@@ -42,6 +42,7 @@ for (const track of videoTracks) {
     inputContainer: container,
     rotationToApply: 0,
     resizeOperation: null,
+    outputVideoCodec: null
   }); // boolean
 }
 ```
@@ -105,6 +106,12 @@ _string_ <TsType type="ResizeOperation" source="@remotion/webcodecs" />
 
 The [resize operation](/docs/webcodecs/resize-a-video) to apply to the video track.
 
+### `outputVideoCodec`
+
+_string | null_ <TsType type="ConvertMediaVideoCodec" source="@remotion/webcodecs" />
+
+The desired video codec of the output media. If `null`, it means you don't care about the video codec as long as it can be copied.
+
 ## Rotation behavior
 
 Any `rotationToApply` is in addition to an auto-rotation that is applied by default to fix the orientation of the video track.

packages/webcodecs/src/can-copy-audio-track.ts

@@ -2,17 +2,32 @@ import type {
 	MediaParserAudioCodec,
 	MediaParserContainer,
 } from '@remotion/media-parser';
+import type {ConvertMediaAudioCodec} from './get-available-audio-codecs';
 import type {ConvertMediaContainer} from './get-available-containers';
+import {isSameAudioCodec} from './is-different-video-codec';
 
 export const canCopyAudioTrack = ({
 	inputCodec,
 	outputContainer,
 	inputContainer,
+	outputAudioCodec,
 }: {
 	inputCodec: MediaParserAudioCodec;
 	outputContainer: ConvertMediaContainer;
 	inputContainer: MediaParserContainer;
+	outputAudioCodec: ConvertMediaAudioCodec | null;
 }) => {
+	if (outputAudioCodec) {
+		if (
+			!isSameAudioCodec({
+				inputAudioCodec: inputCodec,
+				outputCodec: outputAudioCodec,
+			})
+		) {
+			return false;
+		}
+	}
+
 	if (outputContainer === 'webm') {
 		return inputCodec === 'opus';
 	}

packages/webcodecs/src/can-copy-video-track.ts

@@ -3,6 +3,8 @@ import type {
 	MediaParserVideoTrack,
 } from '@remotion/media-parser';
 import type {ConvertMediaContainer} from './get-available-containers';
+import type {ConvertMediaVideoCodec} from './get-available-video-codecs';
+import {isSameVideoCodec} from './is-different-video-codec';
 import type {ResizeOperation} from './resizing/mode';
 import {normalizeVideoRotation} from './rotate-and-resize-video-frame';
 import {calculateNewDimensionsFromRotateAndScale} from './rotation';
@@ -13,11 +15,13 @@ export const canCopyVideoTrack = ({
 	inputContainer,
 	resizeOperation,
 	inputTrack,
+	outputVideoCodec,
 }: {
 	inputContainer: MediaParserContainer;
 	inputTrack: MediaParserVideoTrack;
 	rotationToApply: number;
 	outputContainer: ConvertMediaContainer;
+	outputVideoCodec: ConvertMediaVideoCodec | null;
 	resizeOperation: ResizeOperation | null;
 }) => {
 	if (
@@ -27,6 +31,17 @@ export const canCopyVideoTrack = ({
 		return false;
 	}
 
+	if (outputVideoCodec) {
+		if (
+			!isSameVideoCodec({
+				inputVideoCodec: inputTrack.codecEnum,
+				outputCodec: outputVideoCodec,
+			})
+		) {
+			return false;
+		}
+	}
+
 	const newDimensions = calculateNewDimensionsFromRotateAndScale({
 		height: inputTrack.height,
 		resizeOperation,

packages/webcodecs/src/is-different-video-codec.ts

@@ -0,0 +1,60 @@
+import type {
+	MediaParserAudioCodec,
+	MediaParserVideoCodec,
+} from '@remotion/media-parser';
+import type {ConvertMediaAudioCodec} from './get-available-audio-codecs';
+import type {ConvertMediaVideoCodec} from './get-available-video-codecs';
+
+export const isSameVideoCodec = ({
+	inputVideoCodec,
+	outputCodec,
+}: {
+	inputVideoCodec: MediaParserVideoCodec;
+	outputCodec: ConvertMediaVideoCodec;
+}) => {
+	if (outputCodec === 'h264') {
+		return inputVideoCodec === 'h264';
+	}
+
+	if (outputCodec === 'h265') {
+		return inputVideoCodec === 'h265';
+	}
+
+	if (outputCodec === 'vp8') {
+		return inputVideoCodec === 'vp8';
+	}
+
+	if (outputCodec === 'vp9') {
+		return inputVideoCodec === 'vp9';
+	}
+
+	throw new Error(`Unsupported output codec: ${outputCodec satisfies never}`);
+};
+
+export const isSameAudioCodec = ({
+	inputAudioCodec,
+	outputCodec,
+}: {
+	inputAudioCodec: MediaParserAudioCodec;
+	outputCodec: ConvertMediaAudioCodec;
+}) => {
+	if (outputCodec === 'aac') {
+		return inputAudioCodec === 'aac';
+	}
+
+	if (outputCodec === 'opus') {
+		return inputAudioCodec === 'opus';
+	}
+
+	if (outputCodec === 'wav') {
+		return (
+			inputAudioCodec === 'pcm-f32' ||
+			inputAudioCodec === 'pcm-s16' ||
+			inputAudioCodec === 'pcm-s24' ||
+			inputAudioCodec === 'pcm-s32' ||
+			inputAudioCodec === 'pcm-u8'
+		);
+	}
+
+	throw new Error(`Unsupported output codec: ${outputCodec satisfies never}`);
+};

packages/webcodecs/src/on-audio-track.ts

@@ -45,6 +45,7 @@ export const makeAudioTrackHandler =
 			inputCodec: track.codecEnum,
 			outputContainer,
 			inputContainer,
+			outputAudioCodec: audioCodec,
 		});
 
 		const audioOperation = await (onAudioTrack ?? defaultOnAudioTrackHandler)({

packages/webcodecs/src/on-video-track.ts

@@ -58,6 +58,7 @@ export const makeVideoTrackHandler =
 			rotationToApply: rotate,
 			inputTrack: track,
 			resizeOperation,
+			outputVideoCodec: defaultVideoCodec,
 		});
 
 		const videoOperation = await (onVideoTrack ?? defaultOnVideoTrackHandler)({