Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): RMT-1405: fix error messages for conditional schemas #150

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

lukad
Copy link
Collaborator

@lukad lukad commented Mar 20, 2025

This addresses a bug where validation errors in conditional schemas would not generate correct error messages.
Check out the added tests for concrete examples.

@lukad lukad force-pushed the conditionals-dont-take-into-account-required-keyword branch from f9184aa to b7fc6f2 Compare March 20, 2025 09:02
@lukad lukad force-pushed the conditionals-dont-take-into-account-required-keyword branch from b7fc6f2 to d2cca18 Compare March 20, 2025 09:08
@lukad lukad marked this pull request as ready for review March 20, 2025 09:13
Copy link
Collaborator

@dragidavid dragidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of digging about the big diff in the json file and I think it is all good here.

Looks great!

@lukad lukad merged commit 31a5721 into main Mar 20, 2025
2 checks passed
@lukad lukad deleted the conditionals-dont-take-into-account-required-keyword branch March 20, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants