fix(select): Support integer values #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @js-ta, the team will review this some time next week, is that okay? :) |
|
That's fine for me. |
sandrina-p
changed the title
sandrina-p
force-pushed
the
select-with-integer-value
branch
from
3e84ee3 to
91cc303
Compare
sandrina-p
reviewed
Mar 13, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@remoteoss/json-schema-form", | |||
| "version": "0.11.11-beta.0", | |||
| "version": "0.11.12-dev.20250313084704", | |||
There was a problem hiding this comment.
Hi @js-ta! We are building the next major version of JSF, which will include your bugfix/feature. For that reason we won't review your PR, so we can focus on shipping the next version as soon as possible.
In the meantime, here's a dev release based on this PR to unblock you:
npm i @remoteoss/json-schema-form@0.11.12-dev.20250313084704
We hope that's okay for now. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the issue described in #115 to be able to use integer values in select elements.
It simply handles an integers like a number is handled already in a select and prevents the withInteger schema from being added.