DEVXP-2541: feat(next): add support for format
#128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we had quite a few type errors in the test folder that we missed - linter was checking every folder including the json-schema-test-suite which we don't want - we were missing the `module` from `package.json` resulting in a warning in the console when running tests
- makes it cleaner and easier to understand whats going on
- the schema was the wrong type here
dragidavid
requested review from
lukad,
antoniocapelo,
sandrina-p and
thien-remote
dragidavid
commented
Feb 11, 2025
antoniocapelo
previously approved these changes
Feb 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things. First and foremost, adds support for
formatand it fixes some issues we had around type checking and linting.lintby adding ignored folders to oureslint.config.mjs(we were running lint on thejson-schema-test-suitefolder as well which is not ideal)typecheckscript to look for ts errors in both thesrcand now thetestfolder (we had quite a few ts errors in the test folder that we didn't catch before)checkstep to thebuild-next.ymlfile so we don't miss these errors in the futurejson-schema-test-suiterelated files in their own folder for clarity and ease of understandingLast but not least I re-run the external tests and it resulted in a pretty good diff, lot less tests failing now! I ran this about 5 times to make sure and it seems correct 😅